[coreboot-gerrit] Patch merged into coreboot/master: nb/intel/x4x/raminit: Fix DIMM_IN_CHANNEL calculation
gerrit at coreboot.org
gerrit at coreboot.org
Mon Nov 28 17:56:38 CET 2016
the following patch was just integrated into master:
commit 3c20906e42ed5bf7ef5202fa9eb38c574e43b688
Author: Nico Huber <nico.h at gmx.de>
Date: Sat Nov 26 02:03:25 2016 +0100
nb/intel/x4x/raminit: Fix DIMM_IN_CHANNEL calculation
Fix-up for 696abfc
nb/intel/x4x: Fix and deflate `dimm_config` in raminit
It didn't fix the channel-number shifting issue as intended.
The channel index is either 0 or 1. DIMMs are counted from 0
to 3 where 0..1 covers channel 0, and 2..3 covers channel 1.
Since we have two DIMMs per channel, we have to multiply the
channel index by 2 (or shift it left by 1) to get the index
of the first DIMM in the channel. Finally, to get the offset
of a DIMM in the channel we take its index modulo 2 (again,
the number of DIMMs per channel).
Change-Id: I2784b0cb655bfe823bf5fa48b722623dfca1ddc3
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/17612
Tested-by: build bot (Jenkins)
Reviewed-by: Damien Zammit <damien at zamaudio.com>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
See https://review.coreboot.org/17612 for details.
-gerrit
More information about the coreboot-gerrit
mailing list