[coreboot-gerrit] Patch set updated for coreboot: nb/intel/sandybridge/raminit: Add debugging output

Patrick Rudolph (siro@das-labor.org) gerrit at coreboot.org
Sat Nov 26 16:04:42 CET 2016


Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17608

-gerrit

commit 2b8d1ce81271889510961ce0e618324f6c897054
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Fri Nov 25 15:40:07 2016 +0100

    nb/intel/sandybridge/raminit: Add debugging output
    
    Add debugging output to normalize_training.
    
    Tested on Lenovo T420.
    
    Change-Id: I1d787f7ead6cf35ee142a8848837840c91cb6967
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 src/northbridge/intel/sandybridge/raminit_common.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 82d10c5..3f07632 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -3028,9 +3028,15 @@ void normalize_training(ramctr_timing * ctrl)
 		int delta;
 		FOR_ALL_LANES mat =
 		    max(ctrl->timings[channel][slotrank].lanes[lane].timA, mat);
-		 delta = (mat >> 6) - ctrl->timings[channel][slotrank].val_4028;
-		 ctrl->timings[channel][slotrank].val_4024 += delta;
-		 ctrl->timings[channel][slotrank].val_4028 += delta;
+		printram("normalize %d, %d, %d: mat %d\n",
+		    channel, slotrank, lane, mat);
+
+		delta = (mat >> 6) - ctrl->timings[channel][slotrank].val_4028;
+		printram("normalize %d, %d, %d: delta %d\n",
+		    channel, slotrank, lane, delta);
+
+		ctrl->timings[channel][slotrank].val_4024 += delta;
+		ctrl->timings[channel][slotrank].val_4028 += delta;
 	}
 
 	FOR_ALL_POPULATED_CHANNELS {



More information about the coreboot-gerrit mailing list