[coreboot-gerrit] New patch to review for coreboot: util/lint: Add check to verify saved configs are miniconfigs

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Nov 24 21:17:24 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17600

-gerrit

commit 9b53e52418ba2018a6bf94c591dcd2bba54913fe
Author: Martin Roth <martinroth at google.com>
Date:   Thu Nov 24 13:16:28 2016 -0700

    util/lint: Add check to verify saved configs are miniconfigs
    
    Change-Id: Ifc5ec645dd27663c1b1fde9ff16d48534606a554
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/lint/lint-stable-017-configs | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/util/lint/lint-stable-017-configs b/util/lint/lint-stable-017-configs
new file mode 100755
index 0000000..b8d49de
--- /dev/null
+++ b/util/lint/lint-stable-017-configs
@@ -0,0 +1,33 @@
+#!/bin/sh
+# This file is part of the coreboot project.
+#
+# Copyright (C) 2016 Google Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# DESCR: Check that saved config files are miniconfigs
+
+LC_ALL=C export LC_ALL
+
+SYMBOLS='CONFIG_ARCH_\|CONFIG_MAINBOARD_HAS_'
+
+# Use git grep if the code is in a git repo, otherwise use grep.
+if [ -n "$(command -v git)" ] && [ -d .git ]; then
+	GREP="git grep"
+else
+	GREP="grep -r"
+fi
+
+#look for a couple of things that should only be set by select keywords
+for file in \
+	$($GREP "$SYMBOLS" configs | \
+	sed 's/:.*//' | uniq) ; do \
+		echo "Error: $file seems to be a full config"; \
+	done



More information about the coreboot-gerrit mailing list