[coreboot-gerrit] Patch set updated for coreboot: soc/samsung/exynos5420/uart.c: Init new serial struct variables

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Nov 23 23:16:00 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17482

-gerrit

commit 74ee2f955d2df54529f9fba5209a2636f6171ca1
Author: Martin Roth <martinroth at google.com>
Date:   Fri Nov 18 10:34:24 2016 -0700

    soc/samsung/exynos5420/uart.c: Init new serial struct variables
    
    The lb_serial structure had some new entries added, which were not being
    filled in.
    
    Fill in the values so they're not undefined.
    
    Addresses coverity error 1354778 - Uninitialized scalar variable
    
    Change-Id: Ia7ce07f6e4e058c91c2e063f3225497271ef93ff
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/soc/samsung/exynos5420/uart.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/soc/samsung/exynos5420/uart.c b/src/soc/samsung/exynos5420/uart.c
index 00ed432..6f54c00 100644
--- a/src/soc/samsung/exynos5420/uart.c
+++ b/src/soc/samsung/exynos5420/uart.c
@@ -184,6 +184,8 @@ void uart_fill_lb(void *data)
 	serial.baseaddr = uart_platform_base(CONFIG_UART_FOR_CONSOLE);
 	serial.baud = default_baudrate();
 	serial.regwidth = 4;
+	serial.input_hertz = uart_platform_refclk();
+	serial.uart_pci_addr = 0;
 	lb_add_serial(&serial, data);
 
 	lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data);



More information about the coreboot-gerrit mailing list