[coreboot-gerrit] Patch merged into coreboot/master: spi: Clean up SPI flash driver interface

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 22 17:32:14 CET 2016


the following patch was just integrated into master:
commit c28984d9ea08e7d995ef9fc8064c10ec0c0d9d77
Author: Furquan Shaikh <furquan at chromium.org>
Date:   Sun Nov 20 21:04:00 2016 -0800

    spi: Clean up SPI flash driver interface
    
    RW flag was added to spi_slave structure to get around a requirement on
    some AMD flash controllers that need to group together all spi volatile
    operations (write/erase). This rw flag is not a property or attribute of
    the SPI slave or controller. Thus, instead of saving it in spi_slave
    structure, clean up the SPI flash driver interface. This allows
    chipsets/mainboards (that require volatile operations to be grouped) to
    indicate beginning and end of such grouped operations.
    
    New user APIs are added to allow users to perform probe, read, write,
    erase, volatile group begin and end operations. Callbacks defined in
    spi_flash structure are expected to be used only by the SPI flash
    driver. Any chipset that requires grouping of volatile operations can
    select the newly added Kconfig option SPI_FLASH_HAS_VOLATILE_GROUP and
    define callbacks for chipset_volatile_group_{begin,end}.
    
    spi_claim_bus/spi_release_bus calls have been removed from the SPI flash
    chip drivers which end up calling do_spi_flash_cmd since it already has
    required calls for claiming and releasing SPI bus before performing a
    read/write operation.
    
    BUG=None
    BRANCH=None
    TEST=Compiles successfully.
    
    Change-Id: Idfc052e82ec15b6c9fa874cee7a61bd06e923fbf
    Signed-off-by: Furquan Shaikh <furquan at chromium.org>
    Reviewed-on: https://review.coreboot.org/17462
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/17462 for details.

-gerrit



More information about the coreboot-gerrit mailing list