[coreboot-gerrit] Patch set updated for coreboot: soc/intel/skylake: Initialize UART based on CONFIG_UART_DEBUG

Boon Tiong Teo (boon.tiong.teo@intel.com) gerrit at coreboot.org
Tue Nov 22 11:33:42 CET 2016


Boon Tiong Teo (boon.tiong.teo at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17349

-gerrit

commit c74b8254a6d6901d99a96848afe283d7d29ace59
Author: Teo Boon Tiong <boon.tiong.teo at intel.com>
Date:   Thu Nov 10 21:06:51 2016 +0800

    soc/intel/skylake: Initialize UART based on CONFIG_UART_DEBUG
    
    Current implementation checks for CONFIG_BOOTBLOCK_CONSOLE and then
    initializes UART. If only CONFIG_BOOTBLOCK_CONSOLE
    is enabled without enabling CONFIG_UART_DEBUG, there are
    compilation issues. This is the case when using SIO UART for Skylake
    DT platform. Hence initialize UART when CONFIG_UART_DEBUG is enabled
    and not based on CONFIG_BOOTBLOCK_CONSOLE.
    
    Change-Id: Id422a55a68d64a06fc874bddca46b0ef5be6d596
    Signed-off-by: Teo Boon Tiong <boon.tiong.teo at intel.com>
---
 src/soc/intel/skylake/bootblock/bootblock.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/soc/intel/skylake/bootblock/bootblock.c b/src/soc/intel/skylake/bootblock/bootblock.c
index b00fcf7..e11106e 100644
--- a/src/soc/intel/skylake/bootblock/bootblock.c
+++ b/src/soc/intel/skylake/bootblock/bootblock.c
@@ -27,8 +27,7 @@ void bootblock_soc_early_init(void)
 	bootblock_systemagent_early_init();
 	bootblock_pch_early_init();
 	bootblock_cpu_init();
-
-	if (IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE))
+	if (IS_ENABLED(CONFIG_UART_DEBUG))
 		pch_uart_init();
 }
 



More information about the coreboot-gerrit mailing list