[coreboot-gerrit] New patch to review for coreboot: net/r8167: do net set bus msater enable

[Ronald G. Minnich (rminnich@gmail.com)]

Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17559

-gerrit

commit 64d76c0a7e782217d369284f0996b3e0e6535237
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Mon Nov 21 08:19:11 2016 -0800

    net/r8167: do net set bus msater enable
    
    It's very dangerous to set bus master enable, and more so on
    a NIC, where random broadcast packets can end up in memory
    in unexpected ways.
    
    If your kernel has trouble with the fact that we do not set
    bus master enable, you need to fix your kernel.
    
    Change-Id: If07fde7961ad80125567240cb43db036346bef97
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
---
 src/drivers/net/r8168.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c
index 4301693..1e6db57 100644
--- a/src/drivers/net/r8168.c
+++ b/src/drivers/net/r8168.c
@@ -45,9 +45,9 @@ static void r8168_init(struct device *dev)
 	struct resource *nic_res = find_resource(dev, PCI_BASE_ADDRESS_0);
 	u16 nic_port = (u16)nic_res->base;
 
-	/* Set bus master */
-	pci_write_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER
-					| PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
+	/* Ensble but do not set bus master. That's dangerous on a NIC. */
+	pci_write_config16(dev, PCI_COMMAND,
+			   PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
 
 	/* Reset NIC */
 	printk(BIOS_DEBUG, "r8168: Resetting NIC...");