[coreboot-gerrit] New patch to review for coreboot: cpu/allwinner/a10/uart_console.c: Init new serial struct variables
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Fri Nov 18 20:25:46 CET 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17483
-gerrit
commit 25c8e289d6b51072ff36a81010bd87530926f8a0
Author: Martin Roth <martinroth at google.com>
Date: Fri Nov 18 10:33:20 2016 -0700
cpu/allwinner/a10/uart_console.c: Init new serial struct variables
The lb_serial structure had some new entries added, which were not being
filled in.
Fill in the values so they're not undefined.
Addresses coverity error 1354778 - Uninitialized scalar variable
Change-Id: I57f024c35f79397d0e9fd0c800b1b0f4075caac1
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/cpu/allwinner/a10/uart_console.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/cpu/allwinner/a10/uart_console.c b/src/cpu/allwinner/a10/uart_console.c
index 64c2a4f..1b780a7 100644
--- a/src/cpu/allwinner/a10/uart_console.c
+++ b/src/cpu/allwinner/a10/uart_console.c
@@ -46,6 +46,8 @@ void uart_fill_lb(void *data)
serial.baseaddr = uart_platform_base(CONFIG_UART_FOR_CONSOLE);
serial.baud = default_baudrate();
serial.regwidth = 1;
+ serial.input_hertz = uart_platform_refclk();
+ serial.uart_pci_addr = CONFIG_UART_PCI_ADDR;
lb_add_serial(&serial, data);
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data);
More information about the coreboot-gerrit
mailing list