[coreboot-gerrit] Patch set updated for coreboot: arch/x86/acpigen: acpigen buffer size fix

Naresh Solanki (naresh.solanki@intel.com) gerrit at coreboot.org
Thu Nov 17 05:47:15 CET 2016


Naresh Solanki (naresh.solanki at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17444

-gerrit

commit 8b8aa49b7456cbcd06eb265d64049dcb4c7bb575
Author: Naresh G Solanki <naresh.solanki at intel.com>
Date:   Wed Nov 16 10:10:09 2016 +0530

    arch/x86/acpigen: acpigen buffer size fix
    
    In function definition of acpigen_write_byte_buffer, buffer size written
    using acpigen_emit_byte gives wrong results in generated AML code for
    buffer size greater than one.
    
    Write buffer size using acpigen_write_integer as per ACPI spec 5.0
    section 20.2.5.4 BufferOp.
    
    Change-Id: I0dcb25b24a1b4b592ad820c95f7c2df67a016594
    Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
---
 src/arch/x86/acpigen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index 7115bdb..31b8dac 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -1143,7 +1143,7 @@ void acpigen_write_byte_buffer(uint8_t *arr, uint8_t size)
 
 	acpigen_emit_byte(BUFFER_OP);
 	acpigen_write_len_f();
-	acpigen_emit_byte(size);
+	acpigen_write_byte(size);
 
 	for (i = 0; i < size; i++)
 		acpigen_emit_byte(arr[i]);



More information about the coreboot-gerrit mailing list