[coreboot-gerrit] New patch to review for coreboot: Revert "lint/gitconfig: Enable checkpatch.pl checking of commits"
Nico Huber (nico.h@gmx.de)
gerrit at coreboot.org
Tue Nov 15 23:44:58 CET 2016
Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17440
-gerrit
commit 1961cf2aa2ef5d9f77790a6956ec6a4a6577282d
Author: Nico Huber <nico.h at gmx.de>
Date: Tue Nov 15 23:35:27 2016 +0100
Revert "lint/gitconfig: Enable checkpatch.pl checking of commits"
This reverts commit b18f522bced85deda8a339cdf9aa310478db3a71.
It's too clumsy. Two things here: it overrides the return value of
lint-stable, and it's applied blindly to all files (you can't change
anything in superiotool for example which somehow has it's own style).
I actually like checkpatch but some things just have to be excluded.
I thought, I'd have the time to fix it, but obviously I don't. And
now we have lint errors in the tree.
Change-Id: Ib792311712e62b0fb2b84c98c147a1c43ea94952
---
util/gitconfig/pre-commit | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit
index 70cd6ea..ccf78d3 100755
--- a/util/gitconfig/pre-commit
+++ b/util/gitconfig/pre-commit
@@ -1,3 +1,2 @@
#!/bin/sh
-%MAKE% lint-stable
-git diff --cached | util/lint/checkpatch.pl --no-signoff -q -
+exec %MAKE% lint-stable
More information about the coreboot-gerrit
mailing list