[coreboot-gerrit] Patch set updated for coreboot: crossgcc/buildgcc: Add package version to saved .success file

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Mon Nov 14 20:00:33 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17417

-gerrit

commit f4dbffee12c68ca3204db026a2f430168b0d8b88
Author: Martin Roth <martinroth at google.com>
Date:   Mon Nov 14 11:56:11 2016 -0700

    crossgcc/buildgcc: Add package version to saved .success file
    
    Previously, the .success file for each target didn't save the version,
    of the package that was built.  This created problems when someone
    wanted to update to a new version and could not rebuild.
    
    Change-Id: I9975b198ac4a7de8ff9323502e1cbd0379a1dbb8
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/crossgcc/buildgcc | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 4883754..949e17c 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -359,11 +359,10 @@ generic_build()
 	host_target=$2
 	builddir=$3
 	success=$4
+	version=$5
 
 	fn_exists build_$package || return
 
-	version="$(eval echo \$$package"_VERSION")"
-
 	mkdir -p "$builddir"
 
 	if [ -f "$success" ]; then
@@ -387,12 +386,16 @@ generic_build()
 
 build_for_host()
 {
-	generic_build $1 host build-$1 "${TARGETDIR}/.$1.success"
+	package="$1"
+	version="$(eval echo \$$package"_VERSION")"
+	generic_build "$package" host "build-$package" "${TARGETDIR}/.${package}.${version}.success" "$version"
 }
 
 build_for_target()
 {
-	generic_build $1 target build-${TARGETARCH}-$1 "${TARGETDIR}/.${TARGETARCH}-$1.success"
+	package="$1"
+	version="$(eval echo \$$package"_VERSION")"
+	generic_build "$package" target "build-${TARGETARCH}-$package" "${TARGETDIR}/.${TARGETARCH}-${package}.${version}.success" "$version"
 }
 
 build()



More information about the coreboot-gerrit mailing list