[coreboot-gerrit] Patch set updated for coreboot: vendorcode/amd/agesa: Remove flawed warning

Łukasz Dobrowolski (lukasz@dobrowolski.io) gerrit at coreboot.org
Sat Nov 12 11:58:45 CET 2016


Łukasz Dobrowolski (lukasz at dobrowolski.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17354

-gerrit

commit db47c0714e7bdda2691db936ecb1c786ffeed258
Author: Łukasz Dobrowolski <lukasz at dobrowolski.io>
Date:   Sat Nov 12 11:36:59 2016 +0100

    vendorcode/amd/agesa: Remove flawed warning
    
    The compilation would fail if CFG_MEMORY_LRDIMM_CAPABLE == FALSE
    and BLDOPT_REMOVE_LRDIMMS_SUPPORT == TRUE.
    
    Change-Id: I1be37e368bc4ed07e59d0f0bb967bed11143a65b
    Signed-off-by: Łukasz Dobrowolski <lukasz at dobrowolski.io>
---
 src/vendorcode/amd/agesa/f12/Include/PlatformInstall.h   | 6 ------
 src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h   | 6 ------
 src/vendorcode/amd/agesa/f15/Include/PlatformInstall.h   | 6 ------
 src/vendorcode/amd/agesa/f15tn/Include/PlatformInstall.h | 6 ------
 src/vendorcode/amd/agesa/f16kb/Include/PlatformInstall.h | 6 ------
 5 files changed, 30 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f12/Include/PlatformInstall.h b/src/vendorcode/amd/agesa/f12/Include/PlatformInstall.h
index 171adb5..1fe116a 100644
--- a/src/vendorcode/amd/agesa/f12/Include/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f12/Include/PlatformInstall.h
@@ -2056,12 +2056,6 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
     #endif
   #endif
 #endif
-// Check LRDIMM CODE and LRDIMM CFG item
-#if CFG_MEMORY_LRDIMM_CAPABLE == FALSE
-  #if  BLDOPT_REMOVE_LRDIMMS_SUPPORT == TRUE
-    #error   Warning: LRDIMM capability is false, but LRIDMM support code included
-  #endif
-#endif
 //  Turn off multi-socket based features if only one node...
 #if OPTION_MULTISOCKET == FALSE
   #undef  OPTION_PARALLEL_TRAINING
diff --git a/src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h b/src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h
index 8092ad2..cfcca82 100644
--- a/src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h
@@ -1967,12 +1967,6 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
     #endif
   #endif
 #endif
-// Check LRDIMM CODE and LRDIMM CFG item
-#if CFG_MEMORY_LRDIMM_CAPABLE == FALSE
-  #if  BLDOPT_REMOVE_LRDIMMS_SUPPORT == TRUE
-    #error   Warning: LRDIMM capability is false, but LRIDMM support code included
-  #endif
-#endif
 //  Turn off multi-socket based features if only one node...
 #if OPTION_MULTISOCKET == FALSE
   #undef  OPTION_PARALLEL_TRAINING
diff --git a/src/vendorcode/amd/agesa/f15/Include/PlatformInstall.h b/src/vendorcode/amd/agesa/f15/Include/PlatformInstall.h
index 7d96fef..54f180a 100644
--- a/src/vendorcode/amd/agesa/f15/Include/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f15/Include/PlatformInstall.h
@@ -2067,12 +2067,6 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
     #endif
   #endif
 #endif
-// Check LRDIMM CODE and LRDIMM CFG item
-#if CFG_MEMORY_LRDIMM_CAPABLE == FALSE
-  #if  BLDOPT_REMOVE_LRDIMMS_SUPPORT == TRUE
-    #error   Warning: LRDIMM capability is false, but LRIDMM support code included
-  #endif
-#endif
 //  Turn off multi-socket based features if only one node...
 #if OPTION_MULTISOCKET == FALSE
   #undef  OPTION_PARALLEL_TRAINING
diff --git a/src/vendorcode/amd/agesa/f15tn/Include/PlatformInstall.h b/src/vendorcode/amd/agesa/f15tn/Include/PlatformInstall.h
index d91cec8..334c84e 100644
--- a/src/vendorcode/amd/agesa/f15tn/Include/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f15tn/Include/PlatformInstall.h
@@ -2465,12 +2465,6 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
     #endif
   #endif
 #endif
-// Check LRDIMM CODE and LRDIMM CFG item
-#if CFG_MEMORY_LRDIMM_CAPABLE == FALSE
-  #if  BLDOPT_REMOVE_LRDIMMS_SUPPORT == TRUE
-    #error   Warning: LRDIMM capability is false, but LRIDMM support code included
-  #endif
-#endif
 //  Turn off multi-socket based features if only one node...
 #if OPTION_MULTISOCKET == FALSE
   #undef  OPTION_PARALLEL_TRAINING
diff --git a/src/vendorcode/amd/agesa/f16kb/Include/PlatformInstall.h b/src/vendorcode/amd/agesa/f16kb/Include/PlatformInstall.h
index a313bbb..7ff268d 100644
--- a/src/vendorcode/amd/agesa/f16kb/Include/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f16kb/Include/PlatformInstall.h
@@ -1521,12 +1521,6 @@ CONST UINT32 ROMDATA AmdPlatformTypeCgf = CFG_AMD_PLATFORM_TYPE;
     #endif
   #endif
 #endif
-// Check LRDIMM CODE and LRDIMM CFG item
-#if CFG_MEMORY_LRDIMM_CAPABLE == FALSE
-  #if  BLDOPT_REMOVE_LRDIMMS_SUPPORT == TRUE
-    #error   Warning: LRDIMM capability is false, but LRIDMM support code included
-  #endif
-#endif
 //  Turn off multi-socket based features if only one node...
 #if OPTION_MULTISOCKET == FALSE
   #undef  OPTION_PARALLEL_TRAINING



More information about the coreboot-gerrit mailing list