[coreboot-gerrit] New patch to review for coreboot: src/vboot: mark factory_initialze_tpm() as static

Vadim Bendebury (vbendeb@chromium.org) gerrit at coreboot.org
Fri Nov 11 18:45:38 CET 2016


Vadim Bendebury (vbendeb at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17387

-gerrit

commit f0b248f84bde74ec323aca95c67737a144d9c375
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Fri Nov 11 09:33:43 2016 -0800

    src/vboot: mark factory_initialze_tpm() as static
    
    This function is not used anywhere else in the code.
    
    BRANCH=none
    BUG=none
    TEST=reef and kevin boards (using tpm1.2 and tpm2.0 respectively)
         build successfully.
    
    Change-Id: Ifcc345ae9c22b25fdcfc2e547e70766021d27e32
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
---
 src/include/antirollback.h | 9 ---------
 src/vboot/secdata_tpm.c    | 9 ++++++++-
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/include/antirollback.h b/src/include/antirollback.h
index a48aa20..f61aa85 100644
--- a/src/include/antirollback.h
+++ b/src/include/antirollback.h
@@ -74,15 +74,6 @@ uint32_t tpm_extend_pcr(struct vb2_context *ctx, int pcr,
 uint32_t tpm_clear_and_reenable(void);
 
 /**
- * Perform one-time initializations.
- *
- * Create the NVRAM spaces, and set their initial values as needed.  Sets the
- * nvLocked bit and ensures the physical presence command is enabled and
- * locked.
- */
-uint32_t factory_initialize_tpm(struct vb2_context *ctx);
-
-/**
  * Start the TPM and establish the root of trust for the antirollback mechanism.
  */
 uint32_t setup_tpm(struct vb2_context *ctx);
diff --git a/src/vboot/secdata_tpm.c b/src/vboot/secdata_tpm.c
index 95605f6..357d6e3 100644
--- a/src/vboot/secdata_tpm.c
+++ b/src/vboot/secdata_tpm.c
@@ -329,7 +329,14 @@ uint32_t antirollback_lock_space_rec_hash(void)
 }
 #endif
 
-uint32_t factory_initialize_tpm(struct vb2_context *ctx)
+/**
+ * Perform one-time initializations.
+ *
+ * Create the NVRAM spaces, and set their initial values as needed.  Sets the
+ * nvLocked bit and ensures the physical presence command is enabled and
+ * locked.
+ */
+static uint32_t factory_initialize_tpm(struct vb2_context *ctx)
 {
 	uint32_t result;
 



More information about the coreboot-gerrit mailing list