[coreboot-gerrit] Patch merged into coreboot/master: soc/intel/common/lpss_i2c: simplify API and use common config structure

gerrit at coreboot.org gerrit at coreboot.org
Fri Nov 11 03:11:53 CET 2016


the following patch was just integrated into master:
commit 4668ba77eaf0418eac37fe67ba06a450d3eafe88
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Nov 9 17:09:40 2016 -0600

    soc/intel/common/lpss_i2c: simplify API and use common config structure
    
    The apollolake and skylake had duplicate stanzas of code for
    initializing the i2c buses. Additionally, they also had very
    similar structures for providing settings for the i2c speed
    control. Introduce a new struct lpss_i2c_bus_config and
    utilize it in both apollolake and skylake thereby removing
    the need for SoC-specific structres. The new structure is
    used for initializing a bus fully as the lpss i2c API is
    simplified in that lpss_i2c_init() is only required to be
    called. The struct lpss_i2c_bus_config structure is passed
    in for both initializing and filling in the SSDT information.
    The formerly exposed functions are made static to reduce the
    external API exposure.
    
    BUG=chrome-os-partner:58889
    
    Change-Id: Ib4fa8a7a4de052da75c778a7658741a5a8e0e6b9
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/17348
    Reviewed-by: Furquan Shaikh <furquan at google.com>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>


See https://review.coreboot.org/17348 for details.

-gerrit



More information about the coreboot-gerrit mailing list