[coreboot-gerrit] New patch to review for coreboot: mb/siemens/sitemp_g1p1/cmos.layout: Re-add cmos_defaults_loaded

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Thu Nov 10 13:23:29 CET 2016


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17355

-gerrit

commit 060ea887ab4b6f55e20d5648a323b669b011a22c
Author: Nico Huber <nico.huber at secunet.com>
Date:   Thu Oct 27 12:22:21 2016 +0200

    mb/siemens/sitemp_g1p1/cmos.layout: Re-add cmos_defaults_loaded
    
    I guess it was dropped because its concept was misunderstood. The idea
    is to always have it set to `Yes` in the cmos.default. The user can
    then ack the loading of the defaults by setting it to `No`. If the de-
    faults ever get loaded again, he'll be noticed by the default `Yes`.
    
    Change-Id: I1aa6d75bd5aa153c7b11a6b74564272eaa7cc523
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 src/mainboard/siemens/sitemp_g1p1/cmos.default | 1 +
 src/mainboard/siemens/sitemp_g1p1/cmos.layout  | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/siemens/sitemp_g1p1/cmos.default b/src/mainboard/siemens/sitemp_g1p1/cmos.default
index 9f15a1c..b5305a1 100644
--- a/src/mainboard/siemens/sitemp_g1p1/cmos.default
+++ b/src/mainboard/siemens/sitemp_g1p1/cmos.default
@@ -1,4 +1,5 @@
 boot_option=Fallback
+cmos_defaults_loaded=Yes
 baud_rate=115200
 debug_level=Spew
 power_on_after_fail=Enable
diff --git a/src/mainboard/siemens/sitemp_g1p1/cmos.layout b/src/mainboard/siemens/sitemp_g1p1/cmos.layout
index 7cae2fb..ec84e9d 100644
--- a/src/mainboard/siemens/sitemp_g1p1/cmos.layout
+++ b/src/mainboard/siemens/sitemp_g1p1/cmos.layout
@@ -28,7 +28,8 @@ entries
 # -----------------------------------------------------------------
 # RTC_BOOT_BYTE (coreboot hardcoded)
 384          1       e       4        boot_option
-#386          2       r       1        unused
+#386          1       r       1        unused
+387          1       e       16       cmos_defaults_loaded
 388          4       h       0        reboot_counter
 392          3       e       5        baud_rate
 #395          1       r       1        unused
@@ -165,6 +166,9 @@ enumerations
 15  13  90%
 15  14  95%
 15  15  100%
+# cmos_defaults_loaded
+16  0   No
+16  1   Yes
 # sata_mode
 17  0   AHCI
 17  1   IDE



More information about the coreboot-gerrit mailing list