[coreboot-gerrit] Patch merged into coreboot/master: mrc: Add support for separate training cache in recovery mode

gerrit at coreboot.org gerrit at coreboot.org
Thu Nov 10 00:50:28 CET 2016


the following patch was just integrated into master:
commit cab1c01885e216027086b20c6b0628df7383f487
Author: Furquan Shaikh <furquan at chromium.org>
Date:   Sat Nov 5 23:57:02 2016 -0700

    mrc: Add support for separate training cache in recovery mode
    
    1. Re-factor MRC cache driver to properly select RW_MRC_CACHE or
    RECOVERY_MRC_CACHE based on the boot mode.
     - If normal mode boot, use RW_MRC_CACHE, if available.
     - If recovery mode boot:
        - Retrain memory if RECOVERY_MRC_CACHE not present, or recovery is
        requested explicity with retrain memory request.
        - Use RECOVERY_MRC_CACHE otherwise.
    2. Protect RW and RECOVERY mrc caches in recovery and non-recovery boot
    modes. Check if both are present under one unified region and protect
    that region as a whole. Else try protecting individual regions.
    3. Update training data in appropriate cache:
     - Use RW_MRC_CACHE if normal mode.
     - Use RECOVERY_MRC_CACHE if present in recovery mode. Else use
     RW_MRC_CACHE.
    4. Add proper debug logs to indicate which training data cache is used
    at any point.
    
    BUG=chrome-os-partner:59352
    BRANCH=None
    TEST=Verified that correct cache is used in both normal and recovery
    mode on reef.
    
    Change-Id: Ie79737a1450bd1ff71543e44a5a3e16950e70fb3
    Signed-off-by: Furquan Shaikh <furquan at chromium.org>
    Reviewed-on: https://review.coreboot.org/17242
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/17242 for details.

-gerrit



More information about the coreboot-gerrit mailing list