[coreboot-gerrit] Patch merged into coreboot/master: util/amdfwtool: fix clang warnings

gerrit at coreboot.org gerrit at coreboot.org
Thu Nov 10 00:25:54 CET 2016


the following patch was just integrated into master:
commit 8806f7f6620d8156fddb8039cb5a9b276097a6e5
Author: Martin Roth <martinroth at chromium.org>
Date:   Tue Nov 8 10:44:18 2016 -0700

    util/amdfwtool: fix clang warnings
    
    Various fixes for clang warnings:
    
    warning: arithmetic on a pointer to void is a GNU extension
    - change *rom from void* to char* and cast back to void* as needed
    
    warning: implicit conversion changes signedness
    - In ALIGN macro, pass in value as unsigned
    
    warning: no previous prototype for function
    - Change functions to static
    
    warning: no previous extern declaration for non-static variable
    - Change global variables to static
    
    warning: comparison of integers of different signs
    - Make loop variable 'i' unsigned
    
    warning: variable 'output' may be uninitialized
    - Make sure an output filename was specified
    
    warning: implicit conversion loses integer precision
    - cast fd_stat.st_size to the appropriate type
    
    Change-Id: I0134a79c00938e121e63b52fd63bd502f4cb9e99
    Signed-off-by: Martin Roth <martinroth at chromium.org>
    Reviewed-on: https://review.coreboot.org/17322
    Tested-by: build bot (Jenkins)
    Reviewed-by: Marc Jones <marc at marcjonesconsulting.com>
    Reviewed-by: Marshall Dawson <marshalldawson3rd at gmail.com>


See https://review.coreboot.org/17322 for details.

-gerrit



More information about the coreboot-gerrit mailing list