[coreboot-gerrit] Patch merged into coreboot/master: util/amdfwtool: Update with ROM size command line parameter
gerrit at coreboot.org
gerrit at coreboot.org
Thu Nov 10 00:24:51 CET 2016
the following patch was just integrated into master:
commit 60f1551461a16cf1b6dc294f715a22748dcb501c
Author: Martin Roth <martinroth at chromium.org>
Date: Tue Nov 8 09:55:01 2016 -0700
util/amdfwtool: Update with ROM size command line parameter
Previously, the ROM size was passed into amdfwtool solely as a #define,
meaning that all boards built with the tool would assume the same size
ROM. This became a problem when the default rom for abuild was updated
to be a board with a 256KB ROM.
The temporary solution was to build amdfwtool individually for each
board that needed it. This replaces that workaround by allowing the
ROM size to be passed in as a command line parameter.
- Add the -f | --flashsize option to accept a hex value for the ROM
size.
- Add checks to make sure the ROM size supplied is large enough.
- Because the ROM size is not hardcoded, it needs to be passed to
various functions.
Signed-off-by: Martin Roth <martinroth at chromium.org>
Change-Id: I0ca69cbba54797e0387a6e85935767b4136ef615
Reviewed-on: https://review.coreboot.org/17321
Tested-by: build bot (Jenkins)
Reviewed-by: Marshall Dawson <marshalldawson3rd at gmail.com>
See https://review.coreboot.org/17321 for details.
-gerrit
More information about the coreboot-gerrit
mailing list