[coreboot-gerrit] Patch set updated for coreboot: southbridge/amd: Remove debug echo when building PI

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Nov 9 23:44:17 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17328

-gerrit

commit be186aacada98f0f9595b5c724fbdaef0b717de5
Author: Martin Roth <martinroth at chromium.org>
Date:   Tue Nov 8 13:32:35 2016 -0700

    southbridge/amd: Remove debug echo when building PI
    
    If this information is needed, use make V=1.  That will print the actual
    command, not a command that needs to be updated with every addition if
    it's going to stay in sync.
    
    Change-Id: I64d33d93c7fad3359d8ef78657bdb86d1fb4d4a1
    Signed-off-by: Martin Roth <martinroth at chromium.org>
---
 src/southbridge/amd/pi/hudson/Makefile.inc | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc
index 9ab2c3e..1c8201d 100644
--- a/src/southbridge/amd/pi/hudson/Makefile.inc
+++ b/src/southbridge/amd/pi/hudson/Makefile.inc
@@ -234,35 +234,6 @@ $(obj)/amdfw.rom:	$(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \
 			$(AMDFWTOOL)
 	rm -f $@
 	@printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
-	echo "$(AMDFWTOOL) \
-		$(OPT_HUDSON_XHCI_FWM_FILE) \
-		$(OPT_HUDSON_IMC_FWM_FILE) \
-		$(OPT_HUDSON_GEC_FWM_FILE) \
-		$(OPT_AMD_PUBKEY_FILE) \
-		$(OPT_PSPBTLDR_FILE) \
-		$(OPT_SMUFWM_FILE) \
-		$(OPT_PSPRCVR_FILE) \
-		$(OPT_PUBSIGNEDKEY_FILE) \
-		$(OPT_PSPSCUREOS_FILE) \
-		$(OPT_PSPNVRAM_FILE) \
-		$(OPT_PSPSECUREDEBUG_FILE) \
-		$(OPT_PSPTRUSTLETS_FILE) \
-		$(OPT_TRUSTLETKEY_FILE) \
-		$(OPT_SMUFIRMWARE2_FILE) \
-		$(OPT_SMUSCS_FILE) \
-		$(OPT_2AMD_PUBKEY_FILE) \
-		$(OPT_2PSPBTLDR_FILE) \
-		$(OPT_2SMUFWM_FILE) \
-		$(OPT_2PSPRCVR_FILE) \
-		$(OPT_2PUBSIGNEDKEY_FILE) \
-		$(OPT_2PSPSCUREOS_FILE) \
-		$(OPT_2PSPNVRAM_FILE) \
-		$(OPT_2PSPSECUREDEBUG_FILE) \
-		$(OPT_2PSPTRUSTLETS_FILE) \
-		$(OPT_2TRUSTLETKEY_FILE) \
-		$(OPT_2SMUFIRMWARE2_FILE) \
-		$(OPT_2SMUSCS_FILE) \
-		--output	$@"
 	$(AMDFWTOOL) \
 		$(OPT_HUDSON_XHCI_FWM_FILE) \
 		$(OPT_HUDSON_IMC_FWM_FILE) \



More information about the coreboot-gerrit mailing list