[coreboot-gerrit] New patch to review for coreboot: mainboard/samsung/stumpy: transition away from device_t

Antonello Dettori (dev@dettori.io) gerrit at coreboot.org
Tue Nov 8 20:00:15 CET 2016


Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17304

-gerrit

commit 74f5c26f4596ae00c063753e16b394afe6e36b70
Author: Antonello Dettori <dev at dettori.io>
Date:   Tue Nov 8 18:44:46 2016 +0100

    mainboard/samsung/stumpy: transition away from device_t
    
    Replace the use of the old device_t definition inside
    mainboard/samsung/stumpy.
    
    Change-Id: Ie6209b3b40d9aad0723690e7aeb3edfd0bfcc4a8
    Signed-off-by: Antonello Dettori <dev at dettori.io>
---
 src/mainboard/samsung/stumpy/chromeos.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/samsung/stumpy/chromeos.c b/src/mainboard/samsung/stumpy/chromeos.c
index 96d2b12..01d81d7 100644
--- a/src/mainboard/samsung/stumpy/chromeos.c
+++ b/src/mainboard/samsung/stumpy/chromeos.c
@@ -84,10 +84,11 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 
 int get_write_protect_state(void)
 {
-	device_t dev;
-#ifdef __PRE_RAM__
+#ifdef __SIMPLE_DEVICE__
+	pci_devfn_t dev;
 	dev = PCI_DEV(0, 0x1f, 2);
 #else
+	device_t dev;
 	dev = dev_find_slot(0, PCI_DEVFN(0x1f, 2));
 #endif
 	return (pci_read_config32(dev, SATA_SP) >> FLAG_SPI_WP) & 1;
@@ -95,10 +96,11 @@ int get_write_protect_state(void)
 
 int get_developer_mode_switch(void)
 {
-	device_t dev;
-#ifdef __PRE_RAM__
+#ifdef __SIMPLE_DEVICE__
+	pci_devfn_t dev;
 	dev = PCI_DEV(0, 0x1f, 2);
 #else
+	device_t dev;
 	dev = dev_find_slot(0, PCI_DEVFN(0x1f, 2));
 #endif
 	return (pci_read_config32(dev, SATA_SP) >> FLAG_DEV_MODE) & 1;
@@ -106,10 +108,11 @@ int get_developer_mode_switch(void)
 
 int get_recovery_mode_switch(void)
 {
-	device_t dev;
-#ifdef __PRE_RAM__
+#ifdef __SIMPLE_DEVICE__
+	pci_devfn_t dev;
 	dev = PCI_DEV(0, 0x1f, 2);
 #else
+	device_t dev;
 	dev = dev_find_slot(0, PCI_DEVFN(0x1f, 2));
 #endif
 	return (pci_read_config32(dev, SATA_SP) >> FLAG_REC_MODE) & 1;



More information about the coreboot-gerrit mailing list