[coreboot-gerrit] New patch to review for coreboot: string.h: only guard snprintf() with __ROMCC__

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Tue Nov 8 17:07:46 CET 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17289

-gerrit

commit d93cd1e9d8caab1b64a7330cfa5dbcf66ef14e07
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Nov 8 09:42:13 2016 -0600

    string.h: only guard snprintf() with __ROMCC__
    
    There's no need to keep the snprintf() declaration hidden
    for early stages. romcc is the entity that has issues. Therefore,
    be explicit about when to guard snprintf().
    
    BUG=chromium:663243
    
    Change-Id: Ib4d0879e52c3f73c6ca61ab75f672f0003fca71f
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/include/string.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/string.h b/src/include/string.h
index 5b2486a..f2777a9 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -15,7 +15,7 @@ void *memmove(void *dest, const void *src, size_t n);
 void *memset(void *s, int c, size_t n);
 int memcmp(const void *s1, const void *s2, size_t n);
 void *memchr(const void *s, int c, size_t n);
-#if !defined(__PRE_RAM__)
+#if !defined(__ROMCC__)
 int snprintf(char * buf, size_t size, const char *fmt, ...);
 #endif
 



More information about the coreboot-gerrit mailing list