[coreboot-gerrit] Patch merged into coreboot/master: soc/intel/skylake: Add _ACx methods for TSR0 sensor for fan control

gerrit at coreboot.org gerrit at coreboot.org
Mon Nov 7 20:41:43 CET 2016


the following patch was just integrated into master:
commit bc41ddd44eec93700d8aeffad1c9fc4b19cea9d8
Author: Sumeet Pawnikar <sumeet.r.pawnikar at intel.com>
Date:   Tue Oct 18 10:57:58 2016 +0530

    soc/intel/skylake: Add _ACx methods for TSR0 sensor for fan control
    
    This patch updates below info,
    [1] Delete the DPTF_CPU_ACTIVE_AC* values because these are not
    being used. Hence, removing unnecessary defines.
    [2] Add new DPTF_TSR0_ACTIVE_AC* temperature trip points for TSR0
    external thermal sensor. These trip points are being used by _ACx
    methods to control the fan speed on Skylake-U fan based Lars and
    Kunimitsu platforms.
    [3] Follow up patches are using DPTF_CPU_ACTIVE_AC* temperature trip
    points in board specific acpi/dptf.asl (for lars, kunimitsu, etc) to
    control the fan speed as per the CPU temperature trip points.
    [4] Newly added _ACx methods for thermal sensor TSR0 in this patch
    has nothing to do with DPTF_CPU_ACTIVE_AC*.
    
    We can control fan speed using various different thermal sensors.
    In this patch, we have added new _ACx methods for TSR0 thermal sensor.
    We run the fan at different speeds to cool down the system at different
    TSR0 temperatures.
    
    Similarly, we considered CPU sensor temperature values and ran the fan
    at different speeds to cool down the system.
    
    BUG=chrome-os-partner:51025
    BRANCH=firmware-glados-7820.B
    TEST=Built and booted on kunimitsu and lars EVT boards.
    Verified these _ACx methods with _ART table on these boards
    with different workloads.
    
    Change-Id: Ia7b81e03da936c4a0f69057e43f18efd7c3b9f17
    Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar at intel.com>
    Reviewed-on: https://chromium-review.googlesource.com/332368
    Reviewed-on: https://review.coreboot.org/17067
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/17067 for details.

-gerrit



More information about the coreboot-gerrit mailing list