[coreboot-gerrit] Patch set updated for coreboot: soc/intel/skylake: Avoid use of variable Local0 in TEVT in thermal.asl

Naresh Solanki (naresh.solanki@intel.com) gerrit at coreboot.org
Mon Nov 7 19:23:59 CET 2016


Naresh Solanki (naresh.solanki at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17245

-gerrit

commit 1c15da3cb978c010a8e0bc93f8bfc9fa0b19c94e
Author: Naresh G Solanki <naresh.solanki at intel.com>
Date:   Sun Nov 6 12:42:30 2016 +0530

    soc/intel/skylake: Avoid use of variable Local0 in TEVT in thermal.asl
    
    Avoid use of Local0 variable in TEVT acpi method.
    If mainboard doesn't expose any thermal sensor, then warning is
    generated for variable Local0 not been used.
    
    Change-Id: I0634961a01144e41a8480c8c6ed8b7fdd358e768
    Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
---
 src/soc/intel/skylake/acpi/dptf/thermal.asl | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/soc/intel/skylake/acpi/dptf/thermal.asl b/src/soc/intel/skylake/acpi/dptf/thermal.asl
index 97484e5..d9bd9c0 100644
--- a/src/soc/intel/skylake/acpi/dptf/thermal.asl
+++ b/src/soc/intel/skylake/acpi/dptf/thermal.asl
@@ -17,25 +17,24 @@
 /* Thermal Threshold Event Handler */
 Method (TEVT, 1, NotSerialized)
 {
-	Store (ToInteger (Arg0), Local0)
 
 #ifdef DPTF_TSR0_SENSOR_ID
-	If (LEqual (Local0, DPTF_TSR0_SENSOR_ID)) {
+	If (LEqual (ToInteger (Arg0), DPTF_TSR0_SENSOR_ID)) {
 		Notify (^TSR0, 0x90)
 	}
 #endif
 #ifdef DPTF_TSR1_SENSOR_ID
-	If (LEqual (Local0, DPTF_TSR1_SENSOR_ID)) {
+	If (LEqual (ToInteger (Arg0), DPTF_TSR1_SENSOR_ID)) {
 		Notify (^TSR1, 0x90)
 	}
 #endif
 #ifdef DPTF_TSR2_SENSOR_ID
-	If (LEqual (Local0, DPTF_TSR2_SENSOR_ID)) {
+	If (LEqual (ToInteger (Arg0), DPTF_TSR2_SENSOR_ID)) {
 		Notify (^TSR2, 0x90)
 	}
 #endif
 #ifdef DPTF_TSR3_SENSOR_ID
-	If (LEqual (Local0, DPTF_TSR3_SENSOR_ID)) {
+	If (LEqual (ToInteger (Arg0), DPTF_TSR3_SENSOR_ID)) {
 		Notify (^TSR3, 0x90)
 	}
 #endif



More information about the coreboot-gerrit mailing list