[coreboot-gerrit] New patch to review for coreboot: amd/gardenia: Update xHCI configuration

Marc Jones (marc@marcjonesconsulting.com) gerrit at coreboot.org
Fri Nov 4 00:30:21 CET 2016


Marc Jones (marc at marcjonesconsulting.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17223

-gerrit

commit 4659b26492b4b529a5f5d8b91247a9a58867466e
Author: Marshall Dawson <marshalldawson3rd at gmail.com>
Date:   Thu Oct 13 11:41:50 2016 -0400

    amd/gardenia: Update xHCI configuration
    
    Remove a duplicated check and setting for xHCI during the
    AMD_INIT_RESET callout.  This is handled by the wrapper.  Also
    remove nearby commented code.  EcChannel0 is not a member of
    FCH_RESET_DATA_BLOCK.
    
    Leave the check in AMD_INIT_ENV.  Although AGESA honors what
    was previously requested, additional settings depend on the
    state of Usb.Xhci0Enable.
    
    Original-Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
    Original-Reviewed-by: Marc Jones <marcj303 at gmail.com>
    (cherry picked from commit ca862fbacbe80b1345ad6f23262a9769f05c50fd)
    
    Change-Id: I45a5123e158cd7399d6d286999371d4a0e0fa963
    Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
 src/mainboard/amd/gardenia/BiosCallOuts.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/mainboard/amd/gardenia/BiosCallOuts.c b/src/mainboard/amd/gardenia/BiosCallOuts.c
index df9139f..32b1fec 100644
--- a/src/mainboard/amd/gardenia/BiosCallOuts.c
+++ b/src/mainboard/amd/gardenia/BiosCallOuts.c
@@ -76,9 +76,6 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 	if (StdHeader->Func == AMD_INIT_RESET) {
 		FCH_RESET_DATA_BLOCK *FchParams_reset = (FCH_RESET_DATA_BLOCK *)FchData;
 		printk(BIOS_DEBUG, "Fch OEM config in INIT RESET ");
-		//FchParams_reset->EcChannel0 = TRUE; /* logical devicd 3 */
-		FchParams_reset->FchReset.Xhci0Enable = IS_ENABLED(CONFIG_HUDSON_XHCI_ENABLE);
-		FchParams_reset->FchReset.Xhci1Enable = FALSE;
 		FchParams_reset->EarlyOemGpioTable = oem_gardenia_gpio;
 	} else if (StdHeader->Func == AMD_INIT_ENV) {
 		FCH_DATA_BLOCK *FchParams_env = (FCH_DATA_BLOCK *)FchData;



More information about the coreboot-gerrit mailing list