[coreboot-gerrit] New patch to review for coreboot: amd/gardenia: Remove rev-specific storage setup

Marc Jones (marc@marcjonesconsulting.com) gerrit at coreboot.org
Fri Nov 4 00:30:17 CET 2016


Marc Jones (marc at marcjonesconsulting.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17220

-gerrit

commit 8ac5ca71591ea79db791a57f5879c804b6b3ae2f
Author: Marshall Dawson <marshalldawson3rd at gmail.com>
Date:   Sat Oct 8 10:04:21 2016 -0600

    amd/gardenia: Remove rev-specific storage setup
    
    Gardenia doesn't have the ability to modify settings depending on
    the board ID.
    
    Original-Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
    Original-Reviewed-by: Marc Jones <marcj303 at gmail.com>
    (cherry picked from commit 536b4c424e5259ddbd82469f5f426d3189ff3f89)
    
    Change-Id: I2c928431306c669735cf735042855e95721bb107
    Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
 src/mainboard/amd/gardenia/BiosCallOuts.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/mainboard/amd/gardenia/BiosCallOuts.c b/src/mainboard/amd/gardenia/BiosCallOuts.c
index 44644ce..f7c16b9 100644
--- a/src/mainboard/amd/gardenia/BiosCallOuts.c
+++ b/src/mainboard/amd/gardenia/BiosCallOuts.c
@@ -32,7 +32,6 @@
 #include "northbridge/amd/pi/dimmSpd.h"
 #include "northbridge/amd/pi/agesawrapper.h"
 #include <PlatformMemoryConfiguration.h>
-#include <boardid.h>
 
 static AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr);
 
@@ -90,13 +89,6 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 #endif
 		FchParams_env->Usb.Xhci1Enable = FALSE;
 		FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is unremoveable. */
-
-		/* sata configuration */
-		/* SD configuration */
-		/* Rev F has an on-board eMMC, which only supports SD 2.0 */
-		if (board_id() == 'F') {
-			FchParams_env->Sd.SdConfig = SdVer2;
-		}
 	}
 	printk(BIOS_DEBUG, "Done\n");
 



More information about the coreboot-gerrit mailing list