[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: Update SPI memory mapping constraints

Andrey Petrov (andrey.petrov@intel.com) gerrit at coreboot.org
Fri May 27 00:42:22 CEST 2016


Andrey Petrov (andrey.petrov at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14979

-gerrit

commit 08e0b22cf95b1ee3bc8ad675a8cf13c4b4b90ef7
Author: Andrey Petrov <andrey.petrov at intel.com>
Date:   Thu May 26 15:29:15 2016 -0700

    soc/intel/apollolake: Update SPI memory mapping constraints
    
    MMIO region of 256 KiB under 4 GiB is not decoded by SPI controller
    by hardware design. Current code incorrectly specifies size of that
    region to be 128 KiB. This change corrects the value to 256 KiB.
    
    Change-Id: Idcc67eb3565b800d835e75c0b765dd49d1656938
    Signed-off-by: Andrey Petrov <andrey.petrov at intel.com>
---
 src/soc/intel/apollolake/mmap_boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c
index bf61941..8009ab9 100644
--- a/src/soc/intel/apollolake/mmap_boot.c
+++ b/src/soc/intel/apollolake/mmap_boot.c
@@ -23,8 +23,8 @@
 #include <fmap.h>
 #include <soc/intel/common/nvm.h>
 
-/* The 128 KiB right below 4G are decoded by readonly SRAM, not boot media */
-#define IFD_BIOS_MAX_MAPPED	(CONFIG_IFD_BIOS_END - 128 * KiB)
+/* The 256 KiB right below 4G are decoded by readonly SRAM, not boot media */
+#define IFD_BIOS_MAX_MAPPED	(CONFIG_IFD_BIOS_END - 256 * KiB)
 #define IFD_MAPPED_SIZE		(IFD_BIOS_MAX_MAPPED - CONFIG_IFD_BIOS_START)
 #define IFD_BIOS_SIZE		(CONFIG_IFD_BIOS_END - CONFIG_IFD_BIOS_START)
 



More information about the coreboot-gerrit mailing list