[coreboot-gerrit] New patch to review for coreboot: AMD boards: Drop comment on include file

Thu May 26 10:24:32 CEST 2016

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14968

-gerrit

commit 8bc52e11533a588ada62616853fa120e689a06c3
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu May 26 11:21:02 2016 +0300

    AMD boards: Drop comment on include file
    
    The included file does not declare pm_ioread(), and the
    modified file does not call it either.
    
    Change-Id: I9723caf1062db23b4a3648e07c2dc4c02f862619
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/amd/bettong/mptable.c           | 2 +-
 src/mainboard/amd/olivehill/mptable.c         | 2 +-
 src/mainboard/amd/olivehillplus/mptable.c     | 2 +-
 src/mainboard/amd/parmer/mptable.c            | 2 +-
 src/mainboard/amd/thatcher/mptable.c          | 2 +-
 src/mainboard/asrock/imb-a180/mptable.c       | 2 +-
 src/mainboard/asus/f2a85-m/mptable.c          | 2 +-
 src/mainboard/hp/abm/mptable.c                | 2 +-
 src/mainboard/hp/pavilion_m6_1035dx/mptable.c | 2 +-
 src/mainboard/lenovo/g505s/mptable.c          | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/amd/bettong/mptable.c b/src/mainboard/amd/bettong/mptable.c
index d77d7e9..1c74ae5 100644
--- a/src/mainboard/amd/bettong/mptable.c
+++ b/src/mainboard/amd/bettong/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include "southbridge/amd/pi/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/pi/hudson/hudson.h"
 #include <southbridge/amd/common/amd_pci_util.h>
 
 static void smp_add_mpc_entry(struct mp_config_table *mc, unsigned length)
diff --git a/src/mainboard/amd/olivehill/mptable.c b/src/mainboard/amd/olivehill/mptable.c
index 0899da2..50d1aa3 100644
--- a/src/mainboard/amd/olivehill/mptable.c
+++ b/src/mainboard/amd/olivehill/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include "southbridge/amd/agesa/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/agesa/hudson/hudson.h"
 
 u8 picr_data[0x54] = {
 	0x03,0x04,0x05,0x07,0x0B,0x0A,0x1F,0x1F,0xFA,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
diff --git a/src/mainboard/amd/olivehillplus/mptable.c b/src/mainboard/amd/olivehillplus/mptable.c
index 6f3ea78..a2ba7f4 100644
--- a/src/mainboard/amd/olivehillplus/mptable.c
+++ b/src/mainboard/amd/olivehillplus/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include <southbridge/amd/pi/hudson/hudson.h> /* pm_ioread() */
+#include <southbridge/amd/pi/hudson/hudson.h>
 
 u8 picr_data[0x54] = {
 	0x03,0x04,0x05,0x07,0x0B,0x0A,0x1F,0x1F,0xFA,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
diff --git a/src/mainboard/amd/parmer/mptable.c b/src/mainboard/amd/parmer/mptable.c
index ac2b44b..8f226d5 100644
--- a/src/mainboard/amd/parmer/mptable.c
+++ b/src/mainboard/amd/parmer/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include "southbridge/amd/agesa/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/agesa/hudson/hudson.h"
 
 u8 picr_data[0x54] = {
 	0x1F,0x1f,0x1f,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
diff --git a/src/mainboard/amd/thatcher/mptable.c b/src/mainboard/amd/thatcher/mptable.c
index ecc6959..797f679 100644
--- a/src/mainboard/amd/thatcher/mptable.c
+++ b/src/mainboard/amd/thatcher/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include "southbridge/amd/agesa/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/agesa/hudson/hudson.h"
 
 u8 picr_data[] = {
 	0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F,
diff --git a/src/mainboard/asrock/imb-a180/mptable.c b/src/mainboard/asrock/imb-a180/mptable.c
index 7e4f19d..2fc380f 100644
--- a/src/mainboard/asrock/imb-a180/mptable.c
+++ b/src/mainboard/asrock/imb-a180/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include "southbridge/amd/agesa/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/agesa/hudson/hudson.h"
 
 
 u8 picr_data[0x54] = {
diff --git a/src/mainboard/asus/f2a85-m/mptable.c b/src/mainboard/asus/f2a85-m/mptable.c
index 3203b59..4f00dad 100644
--- a/src/mainboard/asus/f2a85-m/mptable.c
+++ b/src/mainboard/asus/f2a85-m/mptable.c
@@ -22,7 +22,7 @@
 #include <device/pci.h>
 #include <stdint.h>
 #include <string.h>
-#include "southbridge/amd/agesa/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/agesa/hudson/hudson.h"
 
 
 u8 picr_data[] = {
diff --git a/src/mainboard/hp/abm/mptable.c b/src/mainboard/hp/abm/mptable.c
index 7e4f19d..2fc380f 100644
--- a/src/mainboard/hp/abm/mptable.c
+++ b/src/mainboard/hp/abm/mptable.c
@@ -23,7 +23,7 @@
 #include <cpu/amd/amdfam15.h>
 #include <arch/cpu.h>
 #include <cpu/x86/lapic.h>
-#include "southbridge/amd/agesa/hudson/hudson.h" /* pm_ioread() */
+#include "southbridge/amd/agesa/hudson/hudson.h"
 
 
 u8 picr_data[0x54] = {
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c
index 16c92a4..f1cc663 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c
@@ -23,7 +23,7 @@
 #include <device/pci.h>
 #include <stdint.h>
 #include <string.h>
-#include <southbridge/amd/agesa/hudson/hudson.h> /* pm_ioread() */
+#include <southbridge/amd/agesa/hudson/hudson.h>
 
 
 u8 picr_data[0x54] = {
diff --git a/src/mainboard/lenovo/g505s/mptable.c b/src/mainboard/lenovo/g505s/mptable.c
index 16c92a4..f1cc663 100644
--- a/src/mainboard/lenovo/g505s/mptable.c
+++ b/src/mainboard/lenovo/g505s/mptable.c
@@ -23,7 +23,7 @@
 #include <device/pci.h>
 #include <stdint.h>
 #include <string.h>
-#include <southbridge/amd/agesa/hudson/hudson.h> /* pm_ioread() */
+#include <southbridge/amd/agesa/hudson/hudson.h>
 
 
 u8 picr_data[0x54] = {

