[coreboot-gerrit] New patch to review for coreboot: Kconfig: Allow COLLECT_TIMESTAMPS only on supported architectures (x86)

Jonathan Neuschäfer (j.neuschaefer@gmx.net) gerrit at coreboot.org
Wed May 25 01:10:23 CEST 2016


Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14961

-gerrit

commit 1a9ec97867ece6c429a5ea286cfeff4affae478e
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Wed May 25 00:44:32 2016 +0200

    Kconfig: Allow COLLECT_TIMESTAMPS only on supported architectures (x86)
    
    This prevents a potential build failure on all non-x86 architectures,
    when COLLECT_TIMESTAMPS is enabled, by simply not exposing the option
    anymore.
    
    TEST: Booted qemu-piix4 and checked that the CBMEM still contains a
          timestamp section when COLLECT_TIMESTAMPS is enabled.
          Ran "make menuconfig" with qemu-power8 selected and saw that
          COLLECT_TIMESTAMPS was automatically disabled.
    
    Change-Id: I8856bf7815a4fb1daac3fec4b2f871acc9a19fbd
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/Kconfig          | 5 +++++
 src/arch/x86/Kconfig | 1 +
 2 files changed, 6 insertions(+)

diff --git a/src/Kconfig b/src/Kconfig
index f93c2cc..1c622d4 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -210,8 +210,13 @@ config NO_XIP_EARLY_STAGES
 config EARLY_CBMEM_INIT
 	def_bool !LATE_CBMEM_INIT
 
+config HAVE_TIMESTAMP_SUPPORT
+	bool
+	default n
+
 config COLLECT_TIMESTAMPS
 	bool "Create a table of timestamps collected during boot"
+	depends on HAVE_TIMESTAMP_SUPPORT
 	default n
 	help
 	  Make coreboot create a table of timer-ID/timer-value pairs to
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 724c4db..8dbdd8b 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -17,6 +17,7 @@ config ARCH_X86
 	bool
 	default n
 	select PCI
+	select HAVE_TIMESTAMP_SUPPORT
 
 # stage selectors for x86
 



More information about the coreboot-gerrit mailing list