[coreboot-gerrit] Patch set updated for coreboot: filo: Specify libpayload path

Antonello Dettori (dev@dettori.io) gerrit at coreboot.org
Wed May 25 00:06:17 CEST 2016


Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14952

-gerrit

commit 253574d7f08bc3c35593133722118eafc4454df4
Author: Antonello Dettori <dettori.an at gmail.com>
Date:   Mon May 23 22:40:58 2016 +0200

    filo: Specify libpayload path
    
    Fix FILO build when selected as a payload from menuconfig.
    The "make *conf" commands were pointing to the correct path of libpayload
    but "make" wasn't, resulting in a build error.
    
    Change-Id: Ia7592667b1719836d1509e5cbc01d23266fca9fd
    Signed-off-by: Antonello Dettori <dettori.an at gmail.com>
---
 payloads/external/FILO/Makefile | 25 ++++++++-----------------
 1 file changed, 8 insertions(+), 17 deletions(-)

diff --git a/payloads/external/FILO/Makefile b/payloads/external/FILO/Makefile
index 13d3e8f..2c85cec 100644
--- a/payloads/external/FILO/Makefile
+++ b/payloads/external/FILO/Makefile
@@ -15,6 +15,14 @@ unexport KCONFIG_NEGATIVES
 
 all: filo
 
+filo: libpayload
+	echo "    MAKE       FILO $(NAME-y)"
+	$(MAKE) -C filo LIBCONFIG_PATH=../../../libpayload
+
+libpayload: checkout
+	cd ../../libpayload && $(MAKE) defconfig && \
+		$(MAKE) && $(MAKE) DESTDIR=../external/FILO/filo/build install
+
 checkout:
 	echo "    GIT        FILO $(NAME-y)"
 	test -d filo || \
@@ -26,23 +34,6 @@ checkout:
 			git branch -f $(NAME-y) $(TAG-y) && \
 			git checkout $(NAME-y)
 
-config: libpayload
-	echo "    CONFIG     FILO $(NAME-y)"
-	$(MAKE) -C filo defconfig LIBCONFIG_PATH=../../../libpayload
-	# This shows how to force a previously unset .config option *on*
-	#echo "CONFIG_VGAHOOKS=y" >> filo/.config
-	# This shows how to force a previously set .config option *off*
-	#echo "# CONFIG_SMBIOS is not set" >> filo/.config
-	$(MAKE) -C filo oldconfig LIBCONFIG_PATH=../../../libpayload
-
-filo: config
-	echo "    MAKE       FILO $(NAME-y)"
-	$(MAKE) -C filo
-
-libpayload: checkout
-	cd ../../libpayload && $(MAKE) defconfig && \
-		$(MAKE) && $(MAKE) DESTDIR=../external/FILO/filo/build install
-
 clean:
 	test -d filo && $(MAKE) -C filo clean || exit 0
 



More information about the coreboot-gerrit mailing list