[coreboot-gerrit] New patch to review for coreboot: soc/apollolake/memmap: Switch to SIMPLE_DEVICE API
Alexandru Gagniuc (alexandrux.gagniuc@intel.com)
gerrit at coreboot.org
Mon May 23 23:13:36 CEST 2016
Alexandru Gagniuc (alexandrux.gagniuc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14953
-gerrit
commit 5ea5b3d2f02714c033161ae29547e44a3cc1c4b5
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Mon May 23 14:04:58 2016 -0700
soc/apollolake/memmap: Switch to SIMPLE_DEVICE API
memmap.c functionality is designed to be used in more than ramstage.
Therefore, it cannot use ramstage-specific APIs. In this case, the
SIMPLE_DEVICE API offers a more consistent behavior across stages.
Change-Id: Ic381fe1eb773fb0a5fb5887eb67d2228d2f0817d
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/soc/intel/apollolake/memmap.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/soc/intel/apollolake/memmap.c b/src/soc/intel/apollolake/memmap.c
index bf172cb..ae1394f 100644
--- a/src/soc/intel/apollolake/memmap.c
+++ b/src/soc/intel/apollolake/memmap.c
@@ -15,6 +15,14 @@
* GNU General Public License for more details.
*/
+/*
+ * The device_t returned by dev_find_slot() is different than the device_t
+ * passed to pci_write_config32(). If one needs to get access to the config.h
+ * of a device and perform i/o things are incorrect. One is a pointer while
+ * the other is a 32-bit integer.
+ */
+#define __SIMPLE_DEVICE__
+
#include <arch/io.h>
#include <cbmem.h>
#include <device/pci.h>
More information about the coreboot-gerrit
mailing list