[coreboot-gerrit] New patch to review for coreboot: soc/intel/quark: Fix reg_script display

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Mon May 23 01:52:46 CEST 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14948

-gerrit

commit 2df19c7af591181fab9785bd1f1e71cba95cbdf7
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Sun May 22 16:24:36 2016 -0700

    soc/intel/quark: Fix reg_script display
    
    Remove extra ": " following reigster type.
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I57dd40a540d7b5371a6c45174f47a311b83a2aab
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/reg_access.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/soc/intel/quark/reg_access.c b/src/soc/intel/quark/reg_access.c
index 30cc7db..1dd0d3c 100644
--- a/src/soc/intel/quark/reg_access.c
+++ b/src/soc/intel/quark/reg_access.c
@@ -216,21 +216,21 @@ static uint64_t reg_read(struct reg_script_context *ctx)
 		return 0;
 
 	case GPE0_REGS:
-		ctx->display_prefix = "GPE0: ";
+		ctx->display_prefix = "GPE0";
 		value = reg_gpe0_read(step->reg);
 		break;
 
 	case GPIO_REGS:
-		ctx->display_prefix = "GPIO: ";
+		ctx->display_prefix = "GPIO";
 		value = reg_gpio_read(step->reg);
 		break;
 
 	case LEG_GPIO_REGS:
-		ctx->display_prefix = "Legacy GPIO: ";
+		ctx->display_prefix = "Legacy GPIO";
 		value = reg_legacy_gpio_read(step->reg);
 
 	case PCIE_AFE_REGS:
-		ctx->display_prefix = "PCIe AFE: ";
+		ctx->display_prefix = "PCIe AFE";
 		value = reg_pcie_afe_read(step->reg);
 		break;
 
@@ -265,28 +265,28 @@ static void reg_write(struct reg_script_context *ctx)
 		return;
 
 	case GPE0_REGS:
-		ctx->display_prefix = "GPE0: ";
+		ctx->display_prefix = "GPE0";
 		reg_gpe0_write(step->reg, (uint32_t)step->value);
 		break;
 
 	case GPIO_REGS:
-		ctx->display_prefix = "GPIO: ";
+		ctx->display_prefix = "GPIO";
 		reg_gpio_write(step->reg, (uint32_t)step->value);
 		break;
 
 	case LEG_GPIO_REGS:
-		ctx->display_prefix = "Legacy GPIO: ";
+		ctx->display_prefix = "Legacy GPIO";
 		reg_legacy_gpio_write(step->reg, (uint32_t)step->value);
 		break;
 
 	case PCIE_AFE_REGS:
-		ctx->display_prefix = "PCIe AFE: ";
+		ctx->display_prefix = "PCIe AFE";
 		reg_pcie_afe_write(step->reg, (uint32_t)step->value);
 		break;
 
 	case PCIE_RESET:
 		if (ctx->display_features) {
-			ctx->display_prefix = "PCIe reset: ";
+			ctx->display_prefix = "PCIe reset";
 			ctx->display_features &= ~REG_SCRIPT_DISPLAY_REGISTER;
 		}
 		mainboard_gpio_pcie_reset(step->value);



More information about the coreboot-gerrit mailing list