[coreboot-gerrit] New patch to review for coreboot: soc/intel/quark: Add EHCI errata

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Mon May 23 01:51:58 CEST 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14940

-gerrit

commit eab17531f2b03814dc04746786b493f872e11159
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Sun May 22 09:23:49 2016 -0700

    soc/intel/quark: Add EHCI errata
    
    Move the EHCI errata from QuarkFSP into coreboot.
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I424ffd81643fbba9c820b5a8a6809b9412965f8d
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/ehci.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/soc/intel/quark/ehci.c b/src/soc/intel/quark/ehci.c
index 460ef23..ed9112c 100644
--- a/src/soc/intel/quark/ehci.c
+++ b/src/soc/intel/quark/ehci.c
@@ -24,12 +24,25 @@
 #define USB2_PLL2         0x7F03
 #define USB2_COMPBG       0x7F04
 
+/* EHCI Packet Buffer OUT/IN Thresholds, values in number of DWORDs */
+#define EHCI_OUT_THRESHOLD_VALUE        0x7f
+#define EHCI_IN_THRESHOLD_VALUE         0x7f
+
 /* In order to configure the USB PHY to use clk120 (ickusbcoreclk) as PLL
  * reference clock and Port2 as a USB device port, the following sequence must
  * be followed
  */
 static const struct reg_script init_script[] = {
 
+	/* Set packet buffer OUT/IN thresholds */
+	REG_MMIO_RMW32(R_IOH_EHCI_INSNREG01,
+		~(B_IOH_EHCI_INSNREG01_OUT_THRESHOLD_MASK
+			| B_IOH_EHCI_INSNREG01_IN_THRESHOLD_MASK),
+		 (EHCI_OUT_THRESHOLD_VALUE
+			<< B_IOH_EHCI_INSNREG01_OUT_THRESHOLD_BP)
+		 | (EHCI_IN_THRESHOLD_VALUE
+			<< B_IOH_EHCI_INSNREG01_IN_THRESHOLD_BP)),
+
 	/* Sighting #4930631 PDNRESCFG [8:7] of USB2_GLOBAL_PORT = 11b.
 	 * For port 0 & 1 as host and port 2 as device.
 	 */



More information about the coreboot-gerrit mailing list