[coreboot-gerrit] Patch set updated for coreboot: sio/winbond: Expose enter/exit configuration state functions

Timothy Pearson (tpearson@raptorengineering.com) gerrit at coreboot.org
Fri May 20 04:11:56 CEST 2016


Timothy Pearson (tpearson at raptorengineering.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14891

-gerrit

commit 2248c95ab429a2e01a39babd4cd4c67ca24d35a8
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Wed May 18 13:31:05 2016 -0500

    sio/winbond: Expose enter/exit configuration state functions
    
    Certain mainboards, e.g. the ASUS KGPE-D16/KCMA-D8, require
    board-specific configuration changes to the SuperIO.  Expose
    the functions needed to enter and exit configuration mode
    on Winbond devices.
    
    Change-Id: Ic86651872ecafcfe1398201be2b0768bbe460975
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/superio/winbond/common/early_serial.c | 4 ++--
 src/superio/winbond/common/winbond.h      | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/superio/winbond/common/early_serial.c b/src/superio/winbond/common/early_serial.c
index 7bd1707..6482a94 100644
--- a/src/superio/winbond/common/early_serial.c
+++ b/src/superio/winbond/common/early_serial.c
@@ -42,7 +42,7 @@
 #define WINBOND_EXIT_KEY 0xAA
 
 /* Enable configuration: pass entry key '0x87' into index port dev. */
-static void pnp_enter_conf_state(pnp_devfn_t dev)
+void pnp_enter_conf_state(pnp_devfn_t dev)
 {
 	u16 port = dev >> 8;
 	outb(WINBOND_ENTRY_KEY, port);
@@ -50,7 +50,7 @@ static void pnp_enter_conf_state(pnp_devfn_t dev)
 }
 
 /* Disable configuration: pass exit key '0xAA' into index port dev. */
-static void pnp_exit_conf_state(pnp_devfn_t dev)
+void pnp_exit_conf_state(pnp_devfn_t dev)
 {
 	u16 port = dev >> 8;
 	outb(WINBOND_EXIT_KEY, port);
diff --git a/src/superio/winbond/common/winbond.h b/src/superio/winbond/common/winbond.h
index ad5e451..1f7e7b1 100644
--- a/src/superio/winbond/common/winbond.h
+++ b/src/superio/winbond/common/winbond.h
@@ -22,4 +22,7 @@
 
 void winbond_enable_serial(pnp_devfn_t dev, u16 iobase);
 
+void pnp_enter_conf_state(pnp_devfn_t dev);
+void pnp_exit_conf_state(pnp_devfn_t dev);
+
 #endif /* SUPERIO_WINBOND_COMMON_ROMSTAGE_H */



More information about the coreboot-gerrit mailing list