[coreboot-gerrit] Patch merged into coreboot/master: lib/timestamp: Do not initialize cache in timestamp_cache_get()
gerrit at coreboot.org
gerrit at coreboot.org
Thu May 19 18:26:30 CEST 2016
the following patch was just integrated into master:
commit 63e7b5b8a7dc69d1546ccd0d2ee4fcce8a2cc67d
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Mon May 16 16:06:07 2016 -0700
lib/timestamp: Do not initialize cache in timestamp_cache_get()
timestamp_cache_get() would call timestamp_cache_init() whenever it
found a timestamp cache in the TIMESTAMP_CACHE_UNINITIALIZED state.
That means that timestamp_cache_get() will never reurn a cache in the
uninitialized state.
However, timestamp_init() checks against the uninitialized state, as
it does not expect timestamp_cache_get() to perform any initialization.
As a result, the conditional branch can never be reached.
Simply remove the timestamp_cache_init() call from timestamp_cache_get().
Change-Id: I573ffbf948b69948a3b383fa3bc94382f205b8f8
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Reviewed-on: https://review.coreboot.org/14861
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
See https://review.coreboot.org/14861 for details.
-gerrit
More information about the coreboot-gerrit
mailing list