[coreboot-gerrit] Patch set updated for coreboot: lib/timestamp: Do not initialize cache in timestamp_cache_get()
Alexandru Gagniuc (alexandrux.gagniuc@intel.com)
gerrit at coreboot.org
Tue May 17 20:30:06 CEST 2016
Alexandru Gagniuc (alexandrux.gagniuc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14861
-gerrit
commit aebef1ddd9a4da583af8e586a382e7c78d837b48
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Mon May 16 16:06:07 2016 -0700
lib/timestamp: Do not initialize cache in timestamp_cache_get()
timestamp_cache_get() would call timestamp_cache_init() whenever it
found a timestamp cache in the TIMESTAMP_CACHE_UNINITIALIZED state.
That means that timestamp_cache_get() will never reurn a cache in the
uninitialized state.
However, timestamp_init() checks against the uninitialized state, as
it does not expect timestamp_cache_get() to perform any initialization.
As a result, the conditional branch can never be reached.
Simply remove the timestamp_cache_init() call from timestamp_cache_get().
Change-Id: I573ffbf948b69948a3b383fa3bc94382f205b8f8
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/lib/timestamp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c
index ae84c4f..372076c 100644
--- a/src/lib/timestamp.c
+++ b/src/lib/timestamp.c
@@ -86,9 +86,6 @@ static struct timestamp_cache *timestamp_cache_get(void)
ts_cache = car_get_var_ptr((void *)_timestamp);
}
- if (ts_cache && ts_cache->cache_state == TIMESTAMP_CACHE_UNINITIALIZED)
- timestamp_cache_init(ts_cache, 0);
-
return ts_cache;
}
More information about the coreboot-gerrit
mailing list