[coreboot-gerrit] Patch set updated for coreboot: soc/apollolake/romstage: Call console_init before any printk()
Alexandru Gagniuc (alexandrux.gagniuc@intel.com)
gerrit at coreboot.org
Tue May 17 20:29:22 CEST 2016
Alexandru Gagniuc (alexandrux.gagniuc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14864
-gerrit
commit 9a201bcc4c82aee2cf22a64ae3e0f7fe15bc9e2f
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Mon May 16 16:52:54 2016 -0700
soc/apollolake/romstage: Call console_init before any printk()
Follow the convention used on all other platforms and explicitly call
console_init() before any printk(). This call was most likely ommitted
by accident during rebase.
Also remove the "Staring romstage..." message, as console_init() will
print a standardized message. I don't have details on how this message
originally appeared.
Change-Id: Id91f0fc15ecbd3635d67a261907f4c6af9a499ab
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/soc/intel/apollolake/romstage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c
index 8ec94a7..7699b85 100644
--- a/src/soc/intel/apollolake/romstage.c
+++ b/src/soc/intel/apollolake/romstage.c
@@ -127,12 +127,12 @@ asmlinkage void car_stage_entry(void)
struct romstage_handoff *handoff;
struct chipset_power_state *ps = car_get_var_ptr(&power_state);
- printk(BIOS_DEBUG, "Starting romstage...\n");
soc_early_romstage_init();
-
disable_watchdog();
+ console_init();
+
prev_sleep_state = fill_power_state(ps);
/* Make sure the blob does not override our data in CAR */
More information about the coreboot-gerrit
mailing list