[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Fix array indexing error

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Tue May 17 18:11:02 CEST 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14868

-gerrit

commit fa2d3c13bd55b83a3f184a293bf67e6d4fd92f12
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue May 17 08:40:02 2016 -0700

    drivers/intel/fsp2_0: Fix array indexing error
    
    Don't allow an array index of 2 to be processed by the code referencing
    the array.
    
    Found-by: Coverity CID 1353337
    
    TEST=None
    
    Change-Id: I586ca14416a6e40971f8f6f4066fbdb4908ca688
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/drivers/intel/fsp2_0/graphics.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/graphics.c b/src/drivers/intel/fsp2_0/graphics.c
index 1480179..9628a76 100644
--- a/src/drivers/intel/fsp2_0/graphics.c
+++ b/src/drivers/intel/fsp2_0/graphics.c
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2015 Intel Corp.
+ * Copyright (C) 2015 - 2016 Intel Corp.
  * (Written by Alexandru Gagniuc <alexandrux.gagniuc at intel.com> for Intel Corp.)
  *
  * This program is free software; you can redistribute it and/or modify
@@ -67,7 +67,7 @@ enum cb_err fsp_fill_lb_framebuffer(struct lb_framebuffer *framebuffer)
 		return CB_ERR;
 	}
 
-	if (ginfo->pixel_format > ARRAY_SIZE(fsp_framebuffer_format_map)) {
+	if (ginfo->pixel_format => ARRAY_SIZE(fsp_framebuffer_format_map)) {
 		printk(BIOS_ALERT, "FSP set unknown framebuffer format: %d\n",
 		       ginfo->pixel_format);
 		return CB_ERR;



More information about the coreboot-gerrit mailing list