[coreboot-gerrit] New patch to review for coreboot: Fix leaking CONFIG_VGA=y

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Mon May 16 13:55:42 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14823

-gerrit

commit 0525fd3de7aa5e0ec5c850a04083f6e9172f469a
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon May 16 14:49:57 2016 +0300

    Fix leaking CONFIG_VGA=y
    
    Items under DEVICE_SPECIFIC_OPTIONS got selected without
    the driver being selected.
    
    Change-Id: I1797fa6175620a9291873559a6308eaea85a090e
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/drivers/aspeed/common/Kconfig | 4 ++++
 src/drivers/xgi/common/Kconfig    | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/src/drivers/aspeed/common/Kconfig b/src/drivers/aspeed/common/Kconfig
index 0f7056b..cbf9be4 100644
--- a/src/drivers/aspeed/common/Kconfig
+++ b/src/drivers/aspeed/common/Kconfig
@@ -1,6 +1,8 @@
 config DRIVERS_ASPEED_AST_COMMON
 	bool
 
+if DRIVERS_ASPEED_AST_COMMON
+
 if !MAINBOARD_DO_NATIVE_VGA_INIT
 
 config DEVICE_SPECIFIC_OPTIONS # dummy
@@ -8,3 +10,5 @@ config DEVICE_SPECIFIC_OPTIONS # dummy
 	select VGA
 
 endif # MAINBOARD_DO_NATIVE_VGA_INIT
+
+endif # DRIVERS_ASPEED_AST_COMMON
diff --git a/src/drivers/xgi/common/Kconfig b/src/drivers/xgi/common/Kconfig
index e0ed9d6..f6feeb8 100644
--- a/src/drivers/xgi/common/Kconfig
+++ b/src/drivers/xgi/common/Kconfig
@@ -1,6 +1,8 @@
 config DRIVERS_XGI_Z79_COMMON
 	bool
 
+if DRIVERS_XGI_Z79_COMMON
+
 if !MAINBOARD_DO_NATIVE_VGA_INIT
 
 config DEVICE_SPECIFIC_OPTIONS # dummy
@@ -8,3 +10,5 @@ config DEVICE_SPECIFIC_OPTIONS # dummy
 	select VGA
 
 endif # MAINBOARD_DO_NATIVE_VGA_INIT
+
+endif # DRIVERS_XGI_Z79_COMMON



More information about the coreboot-gerrit mailing list