[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Do not use StackBase FSP-M parameter
Andrey Petrov (andrey.petrov@intel.com)
gerrit at coreboot.org
Mon May 16 07:21:23 CEST 2016
Andrey Petrov (andrey.petrov at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14803
-gerrit
commit 2e4a2fcb6e512f03b9aa406dac7dc3b225cb7f43
Author: Andrey Petrov <andrey.petrov at intel.com>
Date: Fri Apr 15 21:32:30 2016 -0700
soc/intel/apollolake: Do not use StackBase FSP-M parameter
Currently, StackBase field doesn't work and changing it from default
value leads to crash.
Change-Id: Id3f3ea9a834d0c04a8381938535109d6a729cca2
Signed-off-by: Andrey Petrov <andrey.petrov at intel.com>
---
src/soc/intel/apollolake/romstage.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c
index 8ec94a7..da53799 100644
--- a/src/soc/intel/apollolake/romstage.c
+++ b/src/soc/intel/apollolake/romstage.c
@@ -238,9 +238,13 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd)
* requests.
* TODO: add checks to avoid overlap/conflict of CAR usage.
*/
+
+ /* fsp does not work with StackBase modified, so use default */
+#if 0
+ /* FIXME: remove this once FSP is fixed */
mupd->FspmArchUpd.StackBase = _car_region_end -
mupd->FspmArchUpd.StackSize;
-
+#endif
arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION;
if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {
More information about the coreboot-gerrit
mailing list