[coreboot-gerrit] Patch set updated for coreboot: soc/apollolake/uart.c: Do not NOOP .set_resources() and friends
Alexandru Gagniuc (alexandrux.gagniuc@intel.com)
gerrit at coreboot.org
Wed May 11 22:14:13 CEST 2016
Alexandru Gagniuc (alexandrux.gagniuc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14771
-gerrit
commit b5a509bf00269938583dadf5b7b22abf1801423c
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Tue May 10 14:46:07 2016 -0700
soc/apollolake/uart.c: Do not NOOP .set_resources() and friends
When SOC_UART_DEBUG was not set, the boot would hang somwhere in
ramstage, as evidenced by POST codes reported from the EC. This was
traced to the .set_resources and .enable_resources members of the UART
PCI driver being set to NOOP.
Although the exact mechanism of failure is not known, this change
eliminates the hang.
Change-Id: Ic2f3d56a964ec890ebfa1e1a7770f1ae2eb22281
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/soc/intel/apollolake/uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c
index 79f8a54..7b50a21 100644
--- a/src/soc/intel/apollolake/uart.c
+++ b/src/soc/intel/apollolake/uart.c
@@ -42,8 +42,8 @@ static void aplk_uart_read_resources(struct device *dev)
static struct device_operations uart_ops = {
.read_resources = aplk_uart_read_resources,
- .set_resources = DEVICE_NOOP,
- .enable_resources = DEVICE_NOOP,
+ .set_resources = pci_dev_set_resources,
+ .enable_resources = pci_dev_enable_resources,
.init = pci_dev_init,
.enable = DEVICE_NOOP
};
More information about the coreboot-gerrit
mailing list