[coreboot-gerrit] Patch merged into coreboot/master: soc/qualcomm/ipq40xx: Return NULL for cbmem_top if DRAM is not initialized

gerrit at coreboot.org gerrit at coreboot.org
Tue May 10 21:49:18 CEST 2016


the following patch was just integrated into master:
commit 8ce14a794825a09557e69d759049e03d7724f09e
Author: Varadarajan Narayanan <varada at codeaurora.org>
Date:   Tue Mar 29 12:30:38 2016 +0530

    soc/qualcomm/ipq40xx: Return NULL for cbmem_top if DRAM is not initialized
    
    DRAM initialization on gale requires ipq blobs to be
    loaded from cbfs. vboot_locator first checks cbmem_find to see if cbmem is
    initialized and contains selected region info, else it falls back to
    vboot work buffer.
    
    Since cbmem_find calls into cbmem_top to identify the location of
    cbmem area, board/chipset is expected to return NULL until the backing
    store is ready, which in this case until DRAM is initialized in
    romstage, return NULL for cbmem_top.
    
    BUG=chrome-os-partner:49249
    TEST=Able to compile and boot to depthcharge. Doesn't crash in
    imd_handle_init_partial_recovery
    BRANCH=none
    
    Change-Id: Iaac24252ee4fb9f59d767730bf9dd68baa42a68f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4849c15dee2d3782ede4ee4157e432bd4d5602f0
    Original-Change-Id: I3722b7ab5a6585a250138c828eb3d7919b0c1178
    Original-Signed-off-by: Varadarajan Narayanan <varada at codeaurora.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/335425
    Original-Commit-Ready: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: https://review.coreboot.org/14660
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/14660 for details.

-gerrit



More information about the coreboot-gerrit mailing list