[coreboot-gerrit] Patch set updated for coreboot: board_status: Add longopt equivalents for older options

[David Hendricks (dhendrix@chromium.org)]

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14736

-gerrit

commit a67888179a7580f6c392a32f3743b12e7f2630d8
Author: David Hendricks <davidhendricks at gmail.com>
Date:   Sat May 7 11:44:05 2016 -0700

    board_status: Add longopt equivalents for older options
    
    Long options can be useful when writing examples and documentation
    as they are more expressive and obvious to the reader.
    
    Change-Id: I39496765ba1f15ccc2ffe1ad730f0f95702f82b8
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
 util/board_status/board_status.sh | 49 ++++++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 21 deletions(-)

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 3dca85f..0ec9e86 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -171,19 +171,19 @@ show_help() {
 	${0} <option>
 
 Options
-    -h
-        Show this message.
-    -C
+    -C, --clobber
         Clobber temporary output when finished. Useful for debugging.
-    -i  <image>
+    -h, --help
+        Show this message.
+    -i, --image  <image>
         Path to coreboot image (Default is $COREBOOT_IMAGE).
-    -r  <host>
+    -r, --remote-host  <host>
         Obtain machine information from remote host (using ssh).
-    -s  </dev/xxx>
+    -s, --serial-device  </dev/xxx>
         Obtain boot log via serial device.
-    -S  <speed>
+    -S, --serial-speed  <speed>
         Set the port speed for the serial device (Default is $SERIAL_PORT_SPEED).
-    -u
+    -u, --upload-results
         Upload results to coreboot.org.
 "
 }
@@ -194,38 +194,45 @@ if [ $? -ne 4 ]; then
 	exit $EXIT_FAILURE
 fi
 
-# TODO: add longopts in the quotes after -l
-ARGS=$(getopt -o Chi:r:s:S:u -l "" -n "$0" -- "$@");
+LONGOPTS="clobber,help,input:,remote-host:upload-results"
+LONGOPTS+=",serial-device:,serial-speed:"
+
+ARGS=$(getopt -o Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@");
 if [ $? != 0 ] ; then echo "Terminating..." >&2 ; exit 1 ; fi
 eval set -- "$ARGS"
 while true ; do
 	case "$1" in
-		-h)
+		# generic options
+		-C|--clobber)
+			CLOBBER_OUTPUT=1
+			;;
+		-h|--help)
 			show_help
 			exit $EXIT_SUCCESS
 			;;
-		-C)
-			CLOBBER_OUTPUT=1
-			;;
-		-i)
+		-i|--input)
 			shift
 			COREBOOT_IMAGE="$1"
 			;;
-		-r)
+		-r|--remote-host)
 			shift
 			REMOTE_HOST="$1"
 			;;
-		-s)
+		-u|--upload-results)
+			UPLOAD_RESULTS=1
+			;;
+
+		# serial port options
+		-s|--serial-device)
 			shift
 			SERIAL_DEVICE="$1"
 			;;
-		-S)
+		-S|--serial-speed)
 			shift
 			SERIAL_PORT_SPEED="$1"
 			;;
-		-u)
-			UPLOAD_RESULTS=1
-			;;
+
+		# error handling
 		--)
 			shift
 			if [ -n "$*" ]; then