[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Add timestamps around all calls to the blob

Alexandru Gagniuc (alexandrux.gagniuc@intel.com) gerrit at coreboot.org
Tue May 10 18:53:01 CEST 2016


Alexandru Gagniuc (alexandrux.gagniuc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14759

-gerrit

commit d25e3de2cb869e4a0c3e17fa1e7a143107967d21
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date:   Fri May 6 08:22:45 2016 -0700

    drivers/intel/fsp2_0: Add timestamps around all calls to the blob
    
    Change-Id: I384cef0f5b4b71dbd7ad6d1d508e7c6395bf3f2d
    Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
 src/drivers/intel/fsp2_0/notify.c       | 16 +++++++++++++++-
 src/drivers/intel/fsp2_0/silicon_init.c |  7 +++++--
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c
index 820bd45..d9de022 100644
--- a/src/drivers/intel/fsp2_0/notify.c
+++ b/src/drivers/intel/fsp2_0/notify.c
@@ -15,6 +15,7 @@
 #include <fsp/api.h>
 #include <fsp/util.h>
 #include <string.h>
+#include <timestamp.h>
 
 struct fsp_notify_params {
 	enum fsp_notify_phase phase;
@@ -25,6 +26,7 @@ typedef asmlinkage enum fsp_status (*fsp_notify_fn)
 
 enum fsp_status fsp_notify(enum fsp_notify_phase phase)
 {
+	enum fsp_status ret;
 	fsp_notify_fn fspnotify;
 	struct fsp_notify_params notify_params = { .phase = phase };
 
@@ -36,5 +38,17 @@ enum fsp_status fsp_notify(enum fsp_notify_phase phase)
 
 	printk(BIOS_DEBUG, "FspNotify %x\n", (uint32_t) phase);
 
-	return fspnotify(&notify_params);
+	if (phase == AFTER_PCI_ENUM)
+		timestamp_add_now(TS_FSP_BEFORE_ENUMERATE);
+	else if (phase == READY_TO_BOOT)
+		timestamp_add_now(TS_FSP_BEFORE_FINALIZE);
+
+	ret = fspnotify(&notify_params);
+
+	if (phase == AFTER_PCI_ENUM)
+		timestamp_add_now(TS_FSP_AFTER_ENUMERATE);
+	else if (phase == READY_TO_BOOT)
+		timestamp_add_now(TS_FSP_AFTER_FINALIZE);
+
+	return ret;
 }
diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index 66043c8..e7d8c54 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -16,6 +16,7 @@
 #include <fsp/api.h>
 #include <fsp/util.h>
 #include <string.h>
+#include <timestamp.h>
 
 struct fsp_header fsps_hdr;
 
@@ -40,10 +41,12 @@ static enum fsp_status do_silicon_init(struct fsp_header *hdr)
 	/* Give SoC/mainboard a chance to populate entries */
 	platform_fsp_silicon_init_params_cb(&upd);
 
+	timestamp_add_now(TS_FSP_SILICON_INIT_START);
 	silicon_init = (void *) (hdr->image_base +
-						hdr->silicon_init_entry_offset);
-
+				 hdr->silicon_init_entry_offset);
 	status = silicon_init(&upd);
+	timestamp_add_now(TS_FSP_SILICON_INIT_END);
+
 	printk(BIOS_DEBUG, "FspSiliconInit returned 0x%08x\n", status);
 	return status;
 }



More information about the coreboot-gerrit mailing list