[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: Fix incorrect semicolon for else in lpc_init
Furquan Shaikh (furquan@google.com)
gerrit at coreboot.org
Tue May 10 16:22:14 CEST 2016
Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14756
-gerrit
commit a8ac21e8bef33a7e770ee9c79bed3a1b6a7ffbc5
Author: Furquan Shaikh <furquan at google.com>
Date: Tue May 10 07:20:52 2016 -0700
soc/intel/apollolake: Fix incorrect semicolon for else in lpc_init
Else case in lpc_init has an incorrect semicolon which causes the else
case block to be executed always. Remove the additional semicolon.
Change-Id: Ifd0f614c6034563f4658125d5fce5414aae5fa01
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
src/soc/intel/apollolake/lpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/apollolake/lpc.c b/src/soc/intel/apollolake/lpc.c
index ce9f001..48dfb1f 100644
--- a/src/soc/intel/apollolake/lpc.c
+++ b/src/soc/intel/apollolake/lpc.c
@@ -58,7 +58,7 @@ static void lpc_init(struct device *dev)
scnt &= ~(SCNT_EN | SCNT_MODE);
if (cfg->serirq_mode == SERIRQ_QUIET)
scnt |= SCNT_EN;
- else if (cfg->serirq_mode == SERIRQ_CONTINUOUS);
+ else if (cfg->serirq_mode == SERIRQ_CONTINUOUS)
scnt |= SCNT_EN | SCNT_MODE;
pci_write_config8(dev, REG_SERIRQ_CTL, scnt);
}
More information about the coreboot-gerrit
mailing list