[coreboot-gerrit] Patch merged into coreboot/master: coreboot_tables: Extend serial port description

gerrit at coreboot.org gerrit at coreboot.org
Mon May 9 17:21:28 CEST 2016


the following patch was just integrated into master:
commit f92a98c56e063b34b83a35ac655ea8127d4b546f
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Wed May 4 11:59:19 2016 -0700

    coreboot_tables: Extend serial port description
    
    Extend the serial port description to include the input clock frequency
    and a payload specific value.
    
    Without the input frequency it is impossible for the payload to compute
    the baud-rate divisor without making an assumption about the frequency.
    This breaks down when the UART is able to support multiple input clock
    frequencies.
    
    Add the UART_PCI_ADDR Kconfig value to specify the unique PCI device
    being used as the console UART.  Specify this value as zero when the
    UART is not on the PCI bus.  Otherwise specify the device using bus,
    device and function along with setting the valid bit.
    
    Currently the only payload to consume these new fields is the EDK-II
    CorebootPayloadPkg.
    
    Testing on Galileo:
    *  Edit the src/mainboard/intel/galileo/Makefile.inc file:
       *  Add "select ADD_FSP_PDAT_FILE"
       *  Add "select ADD_FSP_RAW_BIN"
       *  Add "select ADD_RMU_FILE"
    *  Place the FSP.bin file in the location specified by CONFIG_FSP_FILE
    *  Place the pdat.bin files in the location specified by
       CONFIG_FSP_PDAT_FILE
    *  Place the rmu.bin file in the location specified by CONFIG_RMU_FILE
    *  Build EDK2 CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc to generate
       UEFIPAYLOAD.fd
    *  Testing is successful when CorebootPayloadPkg is able to properly
       initialize the serial port without using built-in values.
    
    Change-Id: Id4b4455bbf9583f0d66c315d38c493a81fd852a8
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
    Reviewed-on: https://review.coreboot.org/14609
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/14609 for details.

-gerrit



More information about the coreboot-gerrit mailing list