[coreboot-gerrit] Patch set updated for coreboot: google/gale: Implement reset

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon May 9 14:06:33 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14663

-gerrit

commit 5e647ca88185a2df2c5021066c7caecf3f320157
Author: Varadarajan Narayanan <varada at codeaurora.org>
Date:   Tue Sep 8 15:12:46 2015 +0530

    google/gale: Implement reset
    
    Implement reset using PSHOLD and remove watchdog
    based reset not needed for ipx40xx.
    
    BUG=chrome-os-partner:49249
    TEST=None. Initial code not sure if it will even compile
    BRANCH=none
    
    Change-Id: Ibd3f9958682ed2e85e778976df3a8e124a7441fd
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 65c8b9dd633f0d402cad7d609563c8aac9bf5115
    Original-Change-Id: I8f0ea3c1b71e86a7ca733965ecbec6954a52f6e3
    Original-Signed-off-by: Varadarajan Narayanan <varada at codeaurora.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/333298
    Original-Commit-Ready: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
---
 src/mainboard/google/gale/reset.c | 25 +------------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/src/mainboard/google/gale/reset.c b/src/mainboard/google/gale/reset.c
index 94dcd4b..47a46d4 100644
--- a/src/mainboard/google/gale/reset.c
+++ b/src/mainboard/google/gale/reset.c
@@ -19,30 +19,7 @@
 #include <soc/iomap.h>
 #include <reset.h>
 
-/* Watchdog bite time set to default reset value */
-#define RESET_WDT_BITE_TIME 0x31F3
-
-/* Watchdog bark time value is kept larger than the watchdog timeout
- * of 0x31F3, effectively disabling the watchdog bark interrupt
- */
-#define RESET_WDT_BARK_TIME (5 * RESET_WDT_BITE_TIME)
-
-static void wdog_reset(void)
-{
-	printk(BIOS_DEBUG, "\nResetting with watchdog!\n");
-
-	write32(APCS_WDT0_EN, 0);
-	write32(APCS_WDT0_RST, 1);
-	write32(APCS_WDT0_BARK_TIME, RESET_WDT_BARK_TIME);
-	write32(APCS_WDT0_BITE_TIME, RESET_WDT_BITE_TIME);
-	write32(APCS_WDT0_EN, 1);
-	write32(APCS_WDT0_CPU0_WDOG_EXPIRED_ENABLE, 1);
-
-	for (;;)
-		;
-}
-
 void hard_reset(void)
 {
-	wdog_reset();
+	write32(GCNT_PSHOLD, 0);
 }



More information about the coreboot-gerrit mailing list