[coreboot-gerrit] Patch merged into coreboot/master: rockchip/rk3399: Set all 4 DVFS voltage rails to 1.1V @300kHz

gerrit at coreboot.org gerrit at coreboot.org
Mon May 9 08:49:34 CEST 2016


the following patch was just integrated into master:
commit 04884b65cc3967245cf4599bc5e9e83811afc45d
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Apr 12 16:06:31 2016 -0700

    rockchip/rk3399: Set all 4 DVFS voltage rails to 1.1V @300kHz
    
    Previous code had several problems:
    * It was only initting 3 of the 4 voltage rails hooked up to PWM
      regulators.
    * It was using a PWM frequency that was out of range.  Apparently from
      testing 300kHz is best.
    * It was initting all rails to .9V.  On my Kevin I needed 1.1V to make
      booting all 6 cores / rebooting reliable.
    
    With this fix both booting all 6 cores in the kernel is reliable (if we
    tell the kernel not to touch the PWM) and the "reboot" command from
    Linux userspace is also reliable (previously it crashed in coreboot).
    
    NOTES:
    * Setting all rails to the same voltage doesn't make a lot of sense.  We
      should figure out what these should _actually_ be.  Presumably the
      little CPU rail can be lower, at least.  ...and we don't use the GPU
      in the BIOS so we should set that lower.
    
    BRANCH=none
    BUG=chrome-os-partner:51922
    TEST=reboot test
    
    Change-Id: I44f6394e43d291cccf3795ad73ee5b21bd949766
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0ac79a7cfb079d23c9d7c4899fdf18c87d05ed0e
    Original-Change-Id: I80996adefd8542d53ecce59e5233c553700b309f
    Original-Signed-off-by: Douglas Anderson <dianders at chromium.org>
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/339151
    Reviewed-on: https://review.coreboot.org/14727
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/14727 for details.

-gerrit



More information about the coreboot-gerrit mailing list