[coreboot-gerrit] New patch to review for coreboot: siemens/mc_tcu3: Don't try to init unsupported panel type
Werner Zeh (werner.zeh@siemens.com)
gerrit at coreboot.org
Mon May 9 08:22:31 CEST 2016
Werner Zeh (werner.zeh at siemens.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14743
-gerrit
commit 0d4e124028b7b1a21a1c73d2bd8ca197bbaecdd9
Author: Werner Zeh <werner.zeh at siemens.com>
Date: Mon May 9 08:14:45 2016 +0200
siemens/mc_tcu3: Don't try to init unsupported panel type
The LCD panel type is read using 4 GPIOs. Of these 16 possible
combinations only 5 are supported right now. If the GPIO setting encodes
an unsupported panel type, there will be no matching hwinfo.hex in cbfs.
Therefore it makes no sense to try to initialize the DisplayPort-2-LVDS
converter. Leave the function instead in this case.
Change-Id: If8c67a3f5be762758d516c4939dd1de4ff1c8ba5
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
src/mainboard/siemens/mc_tcu3/lcd_panel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mainboard/siemens/mc_tcu3/lcd_panel.c b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
index 1d1f3f9..f48bd56 100644
--- a/src/mainboard/siemens/mc_tcu3/lcd_panel.c
+++ b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
@@ -67,6 +67,7 @@ int setup_lcd_panel(void)
break;
default:
printk(BIOS_ERR, "LCD: No supported panel found.\n");
+ return 1;
break;
}
More information about the coreboot-gerrit
mailing list