[coreboot-gerrit] New patch to review for coreboot: nb/amd/mct_ddr3: Do not wait for predriver code application
Timothy Pearson (tpearson@raptorengineeringinc.com)
gerrit at coreboot.org
Sun May 8 00:31:19 CEST 2016
Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14740
-gerrit
commit b85908324bdc1673ebe55550e01dab9abf5e43d1
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date: Sat May 7 17:29:52 2016 -0500
nb/amd/mct_ddr3: Do not wait for predriver code application
The workaround for predriver calibration application is no longer
required as multiple previous commits have stabilized memory
clock changes. Remove the workaround to prevent lockups on
certain combinations of mainboards, CPUs, and DIMMs.
Change-Id: Iae72bda87dd752705715c063662152c2b7d800ba
Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index 4fa7e66..53f1550 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -7307,24 +7307,6 @@ static void InitPhyCompensation(struct MCTStatStruc *pMCTstat,
dword &= ~(0xffff);
dword |= (0x8000 | tx_pre);
Set_NB32_index_wait_DCT(dev, dct, index_reg, 0x0d0f2202, dword);
-
- if (!is_model10_1f()) {
- /* Be extra safe and wait for the predriver calibration
- * to be applied to the hardware. The BKDG does not
- * require this, but it does take some time for the
- * data to propagate, so it's probably a good idea.
- */
- uint8_t predriver_cal_pending = 1;
- printk(BIOS_DEBUG, "Waiting for predriver calibration to be applied...");
- while (predriver_cal_pending) {
- predriver_cal_pending = 0;
- for (index = 0; index < 0x9; index++) {
- if (Get_NB32_index_wait_DCT(dev, dct, index_reg, 0x0d0f0002 | (index << 8)) & 0x8000)
- predriver_cal_pending = 1;
- }
- }
- printk(BIOS_DEBUG, "done!\n");
- }
} else {
dword = Get_NB32_index_wait_DCT(dev, dct, index_reg, 0x00);
dword = 0;
More information about the coreboot-gerrit
mailing list