[coreboot-gerrit] New patch to review for coreboot: siemens/mc_tcu3: Remove unneeded variable assignment

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat May 7 08:28:26 CEST 2016


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14699

-gerrit

commit e81ae42afae40d654a6b631cc1a7912cbbc48c5f
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat May 7 08:18:18 2016 +0200

    siemens/mc_tcu3: Remove unneeded variable assignment
    
    Assigning the value `1` to `status` in the default branch of the switch
    statement is not needed, as the stored value is overwritten before it
    can be used.
    
    Change-Id: I532b0e217ff4ed315cd30b08d339c755c6df7539
    Found-by: Coverity, CID 1355008: Code maintainability issues (UNUSED_VALUE))
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/siemens/mc_tcu3/lcd_panel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mainboard/siemens/mc_tcu3/lcd_panel.c b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
index 214773a..50fedf4 100644
--- a/src/mainboard/siemens/mc_tcu3/lcd_panel.c
+++ b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
@@ -66,7 +66,6 @@ int setup_lcd_panel(void)
 		break;
 	default:
 		printk(BIOS_ERR, "LCD: No supported panel found.\n");
-		status = 1;
 		break;
 	}
 	/* Now that we have the panel type, setup the DP2LVDS converter */



More information about the coreboot-gerrit mailing list